From: David Miller <davem@davemloft.net>
To: kernel@kasperkp.dk
Cc: mcarlson@broadcom.com, mchan@broadcom.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] tg3: fix VLAN tagging regression
Date: Wed, 21 Sep 2011 02:15:51 -0400 (EDT) [thread overview]
Message-ID: <20110921.021551.1015460502805882165.davem@davemloft.net> (raw)
In-Reply-To: <4E79168D.4080201@kasperkp.dk>
From: Kasper Pedersen <kernel@kasperkp.dk>
Date: Wed, 21 Sep 2011 00:41:17 +0200
> commit 92cd3a17ce9c719abb4c28dee3438e0c641f8de4
> tg3: Simplify tx bd assignments
>
> broke VLAN tagging on outbound packets.
> It ifdef'ed BCM_KERNEL_SUPPORTS_8021Q, but this
> is not set anywhere. So vlan never gets set, and
> all packets are sent with vlan=0.
>
> v2: We can just remove the test. vlan_tx_tag_present
> is valid regardless of whether the 802.1q module
> is built.
>
> Tested on BCM5721 rev 11.
>
> Signed-off-by: Kasper Pedersen <kernel@kasperkp.dk>
Applied.
prev parent reply other threads:[~2011-09-21 6:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 20:48 [PATCH] tg3: fix VLAN tagging regression Kasper Pedersen
2011-09-20 21:09 ` Matt Carlson
2011-09-20 21:27 ` Jesse Gross
2011-09-20 21:57 ` Kasper Pedersen
2011-09-20 22:08 ` Eric Dumazet
2011-09-20 22:11 ` Eric Dumazet
2011-09-20 22:41 ` [PATCH v2] " Kasper Pedersen
2011-09-21 6:15 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110921.021551.1015460502805882165.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kernel@kasperkp.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).