From: Seth Forshee <seth.forshee@canonical.com>
To: Corentin Chary <corentin.chary@gmail.com>
Cc: Matthew Garrett <mjg@redhat.com>,
Azael Avalos <coproscefalo@gmail.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] toshiba_acpi: Convert to use acpi_driver
Date: Wed, 21 Sep 2011 08:24:12 -0500 [thread overview]
Message-ID: <20110921132412.GB23254@thinkpad-t410> (raw)
In-Reply-To: <CAHR064iA1877cF1rmUhX_41U_yjRGs6siswpoMPjs=WEYEm8cQ@mail.gmail.com>
On Wed, Sep 21, 2011 at 09:28:30AM +0200, Corentin Chary wrote:
> On Tue, Sep 20, 2011 at 11:55 PM, Seth Forshee
> <seth.forshee@canonical.com> wrote:
> > Changes toshiba_acpi to register an acpi driver and eliminates the
> > platform device it was using.
>
> Why to you want to remove the platform device ? If you want to create
> a sysfs interface later, you'll probably need it. Most of the platform
> driver I know only use the acpi_device to send proc/netlink events and
> the platform_device is used everywhere else. (And anyway, it's an x86
> *platform* driver, not a pure acpi driver).
I removed the platform device because it seems a bit redundant to have
both, and I don't see what benefit it really provides. I see your point
that conceptually it makes sense to have it has a platform device,
although the distinction there is pretty fine.
Anyway, I guess the cost of keeping the platform device in place is
pretty small, so I can add it back in if that's desirable.
> > Also eliminates most global
> > variables, moving them into toshiba_acpi_dev, along with some
> > other miscellaneous fixes and cleanup.
>
> Good ! Next step would be to deprecate the /proc interface (keeping it
> for compatibility) and adding a new shinny
> /sys/platform/device/toshiba-acpi/ interface correctly documented in
> Documentation/ABI/ :).
I was avoiding chainging any userspace interfaces in this first round of
patches, but deprecating the proc interface is definitely something I'd
like to do. I don't know if there's any point to moving it to sysfs
though. Most of it already has sysfs interfaces via device classes, and
I don't know that there's any value in the rest of it.
Thanks,
Seth
next prev parent reply other threads:[~2011-09-21 13:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 21:55 [PATCH 0/6] toshiba_acpi: Cleanup and TOS1900 device support Seth Forshee
2011-09-20 21:55 ` [PATCH 1/6] toshiba_acpi: Convert to use acpi_driver Seth Forshee
2011-09-20 22:17 ` Joe Perches
2011-09-21 7:31 ` Corentin Chary
2011-09-21 12:52 ` Seth Forshee
2011-09-21 7:28 ` Corentin Chary
2011-09-21 13:24 ` Seth Forshee [this message]
2011-09-21 13:30 ` Corentin Chary
2011-09-21 15:13 ` Azael Avalos
2011-09-21 15:35 ` Matthew Garrett
2011-09-20 21:55 ` [PATCH 2/6] toshiba_acpi: Fix up return codes Seth Forshee
2011-09-20 21:55 ` [PATCH 3/6] toshiba_acpi: Use handle for HCI calls Seth Forshee
2011-09-20 21:55 ` [PATCH 4/6] toshiba_acpi: Support SPFC as an HCI method Seth Forshee
2011-09-20 21:55 ` [PATCH 5/6] toshiba_acpi: Don't add devices for unsupported features Seth Forshee
2011-09-20 21:55 ` [PATCH 6/6] toshiba_acpi: Initialize brightness in backlight device Seth Forshee
2011-09-21 15:31 ` [PATCH 0/6] toshiba_acpi: Cleanup and TOS1900 device support Matthew Garrett
2011-09-21 16:10 ` Seth Forshee
2011-10-26 13:54 ` Seth Forshee
2011-10-26 16:58 ` Azael Avalos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110921132412.GB23254@thinkpad-t410 \
--to=seth.forshee@canonical.com \
--cc=coproscefalo@gmail.com \
--cc=corentin.chary@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox