Re: [PATCH] perf, tool, record: Fix the header generation for pipe

Arnaldo Carvalho de Melo
2011-08-29T14:26:19Z

Em Mon, Aug 29, 2011 at 03:41:47PM +0200, Jiri Olsa escreveu:
> On Mon, Aug 29, 2011 at 10:20:37AM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Mon, Aug 22, 2011 at 06:07:13PM +0200, Jiri Olsa escreveu:
> > > On Mon, Aug 22, 2011 at 05:51:06PM +0200, Eric Dumazet wrote:
> > > > Are you sure length cannot change between the two phases ?
> >
> > > > /proc/kallsyms can definitely change when a module is loaded.
> >
> > > Right, better to store it to a temp file as you suggest, so we have
> > > consistent view.. I'll prepare new patch.
> >
> > Hi Jiri, any news here?
> >
> > I just stumbled in this bug while testing Neil's net_dropmonitor script
> > :-\
>
> well, I was thinking about taking files snapshot, so we dont read them
> twice and omit the reading for size.. but it'll be probably bigger
> change, I'll try to send out something by the end of the week

Yeah, at least one thing there I plan to remove, i.e. no need to copy
kallsyms when we have build ids, just stash the build id and use it
later to get the right symtab to resolve symbols.

> if you need workaround, the initial patch should work

Ok, thanks.

- Arnaldo