From: Grant Likely <grant.likely@secretlab.ca>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Daniel Drake <dsd@laptop.org>,
sameo@linux.intel.com, devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, dilinger@queued.net
Subject: Re: [PATCH 3/3] gpio-vx855: Add device tree binding
Date: Wed, 21 Sep 2011 10:29:06 -0600 [thread overview]
Message-ID: <20110921162906.GY7781@ponder.secretlab.ca> (raw)
In-Reply-To: <20110921125051.GB25620@sirena.org.uk>
On Wed, Sep 21, 2011 at 01:50:52PM +0100, Mark Brown wrote:
> On Wed, Sep 21, 2011 at 01:02:14PM +0100, Daniel Drake wrote:
>
> > +- #gpio-cells : Should be two. The first cell is the pin number and the
> > + second cell is used to specify optional parameters:
> > + - bit 0 specifies polarity (0 for normal, 1 for inverted)
>
> Shouldn't we just have a property for the polarity?
A flags cell in gpio specifiers (and irq specifiers for that matter) is
well established practice.
g.
next prev parent reply other threads:[~2011-09-21 16:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-21 12:02 [PATCH 3/3] gpio-vx855: Add device tree binding Daniel Drake
2011-09-21 12:50 ` Mark Brown
2011-09-21 13:04 ` Daniel Drake
2011-09-21 16:29 ` Grant Likely [this message]
2011-09-21 16:37 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2011-09-28 9:08 Daniel Drake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110921162906.GY7781@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dilinger@queued.net \
--cc=dsd@laptop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).