* xen_biovec_phys_mergeable not exported
@ 2011-09-20 20:25 Matthew Wilcox
2011-09-21 12:09 ` Jens Axboe
0 siblings, 1 reply; 3+ messages in thread
From: Matthew Wilcox @ 2011-09-20 20:25 UTC (permalink / raw)
To: linux-kernel; +Cc: Jens Axboe
In my NVMe driver, I call BIOVEC_PHYS_MERGEABLE(). If CONFIG_XEN
is defined, it references xen_biovec_phys_mergeable() which is not
EXPORT_SYMBOL. I think BIOVEC_PHYS_MERGABLE is a perfectly kosher thing
to be calling from a module that implements a bio-based block driver,
so I think the right thing to do is to add an EXPORT_SYMBOL(_GPL?) to
the Xen code when I submit the driver.
Does anyone have a different opinion on this?
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: xen_biovec_phys_mergeable not exported
2011-09-20 20:25 xen_biovec_phys_mergeable not exported Matthew Wilcox
@ 2011-09-21 12:09 ` Jens Axboe
2011-09-21 18:46 ` Konrad Rzeszutek Wilk
0 siblings, 1 reply; 3+ messages in thread
From: Jens Axboe @ 2011-09-21 12:09 UTC (permalink / raw)
To: Matthew Wilcox; +Cc: linux-kernel@vger.kernel.org
On 2011-09-20 22:25, Matthew Wilcox wrote:
>
> In my NVMe driver, I call BIOVEC_PHYS_MERGEABLE(). If CONFIG_XEN
> is defined, it references xen_biovec_phys_mergeable() which is not
> EXPORT_SYMBOL. I think BIOVEC_PHYS_MERGABLE is a perfectly kosher thing
> to be calling from a module that implements a bio-based block driver,
> so I think the right thing to do is to add an EXPORT_SYMBOL(_GPL?) to
> the Xen code when I submit the driver.
>
> Does anyone have a different opinion on this?
Yep, lets just export it for now. Long term, that functionality will be
moving back into the block layer when we unify the queuing models.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: xen_biovec_phys_mergeable not exported
2011-09-21 12:09 ` Jens Axboe
@ 2011-09-21 18:46 ` Konrad Rzeszutek Wilk
0 siblings, 0 replies; 3+ messages in thread
From: Konrad Rzeszutek Wilk @ 2011-09-21 18:46 UTC (permalink / raw)
To: Jens Axboe; +Cc: Matthew Wilcox, linux-kernel@vger.kernel.org
On Wed, Sep 21, 2011 at 02:09:40PM +0200, Jens Axboe wrote:
> On 2011-09-20 22:25, Matthew Wilcox wrote:
> >
> > In my NVMe driver, I call BIOVEC_PHYS_MERGEABLE(). If CONFIG_XEN
> > is defined, it references xen_biovec_phys_mergeable() which is not
> > EXPORT_SYMBOL. I think BIOVEC_PHYS_MERGABLE is a perfectly kosher thing
> > to be calling from a module that implements a bio-based block driver,
> > so I think the right thing to do is to add an EXPORT_SYMBOL(_GPL?) to
> > the Xen code when I submit the driver.
I am OK with that.
> >
> > Does anyone have a different opinion on this?
>
> Yep, lets just export it for now. Long term, that functionality will be
> moving back into the block layer when we unify the queuing models.
>
> --
> Jens Axboe
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-09-21 18:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-20 20:25 xen_biovec_phys_mergeable not exported Matthew Wilcox
2011-09-21 12:09 ` Jens Axboe
2011-09-21 18:46 ` Konrad Rzeszutek Wilk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).