Re: [patch] agp: potential info leak in compat_agpioc_info_wrap()

Dan Carpenter
2011-09-23T07:32:53Z

On Fri, Sep 23, 2011 at 09:04:15AM +0200, Eric Dumazet wrote:
> > The agp_info32 struct has a 4 byte hole in it so we need to clear
> > that before copying it to userspace.
> >
> > struct agp_info32 {
> > struct agp_version version; /* 0 0 */
> >
> > /* XXX 4 bytes hole, try to pack */
> >
>
> This makes no sense :
>
> Why should we have a 32bit hole before an u32 field ?
>

Crap. You're right. It saw the agp_version struct as a hole.

Sorry for the noise.

regards,
dan carpenter