From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753000Ab1IWXAv (ORCPT ); Fri, 23 Sep 2011 19:00:51 -0400 Received: from smtp-out.google.com ([216.239.44.51]:11940 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752977Ab1IWXAu (ORCPT ); Fri, 23 Sep 2011 19:00:50 -0400 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=date:from:to:cc:subject:message-id:in-reply-to:references: x-mailer:mime-version:content-type: content-transfer-encoding:x-system-of-record; b=NWLV5ryTPxxttFeOljyrb9g3Fx1hBVwvnNEeqK7ViWAKnnUik6l5aCK/xS15gxWEi 7Xd1sMRcPzvHtNZx554zw== Date: Fri, 23 Sep 2011 16:00:35 -0700 From: Andrew Morton To: Bryan Wu Cc: rpurdie@rpsys.net, linux@arm.linux.org.uk, linux-kernel@vger.kernel.org, linus.walleij@linaro.org, Andrew Morton Subject: Re: [PATCH v2] leds: set LEDS_TRIGGERS as tristate Message-Id: <20110923160035.38e42c32.akpm@google.com> In-Reply-To: <1315259762-9034-1-git-send-email-bryan.wu@canonical.com> References: <1315259762-9034-1-git-send-email-bryan.wu@canonical.com> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 6 Sep 2011 05:56:02 +0800 Bryan Wu wrote: > LEDS_TRIGGERS is depends on LEDS_CLASSS, which should be tristate. So > set it as tristate too and update header files as well. > This patch is causing breakage in today's linux-next. x86 allmodconfig: drivers/mmc/core/core.c: In function 'mmc_request_done': drivers/mmc/core/core.c:153: error: 'struct mmc_host' has no member named 'led' drivers/mmc/core/core.c: In function 'mmc_start_request': drivers/mmc/core/core.c:237: error: 'struct mmc_host' has no member named 'led'