public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@google.com>
To: Bryan Wu <bryan.wu@canonical.com>
Cc: rpurdie@rpsys.net, linux@arm.linux.org.uk,
	linux-kernel@vger.kernel.org, linus.walleij@linaro.org,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2] leds: set LEDS_TRIGGERS as tristate
Date: Fri, 23 Sep 2011 16:26:43 -0700	[thread overview]
Message-ID: <20110923162643.d3505bf7.akpm@google.com> (raw)
In-Reply-To: <1315259762-9034-1-git-send-email-bryan.wu@canonical.com>

On Tue,  6 Sep 2011 05:56:02 +0800
Bryan Wu <bryan.wu@canonical.com> wrote:

> LEDS_TRIGGERS is depends on LEDS_CLASSS, which should be tristate. So
> set it as tristate too and update header files as well.
> 

Another allmodconfig failure:

drivers/built-in.o: In function `led_trigger_blink':
(.text+0x119206): undefined reference to `led_blink_set'
drivers/built-in.o: In function `led_trigger_set':
(.text+0x119389): undefined reference to `led_brightness_set'

I *think* it will be caused by this patch.  I'll drop it and see :(

  parent reply	other threads:[~2011-09-23 23:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-05 21:56 [PATCH v2] leds: set LEDS_TRIGGERS as tristate Bryan Wu
2011-09-08 22:41 ` Bryan Wu
2011-09-23 23:00 ` Andrew Morton
2011-09-23 23:26 ` Andrew Morton [this message]
2011-09-27  7:13   ` Bryan Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110923162643.d3505bf7.akpm@google.com \
    --to=akpm@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=bryan.wu@canonical.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox