Re: [GIT PULL 00/12] perf tools fixes

Linus Torvalds
2011-09-23T21:05:47Z

[-- Attachment #1: Type: text/plain, Size: 354 bytes --]

On Fri, Sep 23, 2011 at 2:03 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> But it obviously doesn't affect the kernel compile. It *does* affect
> the perf tool compile, and util/python.c no longer compiles because
> the byte-swap flag isn't passed to it.

This stupid patch makes it compile. But see the comment..

Linus

[-- Attachment #2: patch.diff --]
[-- Type: text/x-patch, Size: 752 bytes --]

tools/perf/util/python.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/tools/perf/util/python.c b/tools/perf/util/python.c
index cbc8f215d4b7..0d50277936f5 100644
--- a/tools/perf/util/python.c
+++ b/tools/perf/util/python.c
@@ -803,7 +803,8 @@ static PyObject *pyrf_evlist__read_on_cpu(struct pyrf_evlist *pevlist,
first = list_entry(evlist->entries.next, struct perf_evsel, node);
err = perf_event__parse_sample(event, first->attr.sample_type,
perf_evsel__sample_size(first),
- sample_id_all, &pevent->sample);
+ sample_id_all, &pevent->sample,
+ 0 /* really? */);
if (err)
return PyErr_Format(PyExc_OSError,
"perf: can't parse sample, err=%d", err);