From: Christoph Hellwig <hch@infradead.org>
To: Shaohua Li <shaohua.li@intel.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Jens Axboe <axboe@kernel.dk>,
Andrew Morton <akpm@linux-foundation.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [patch]mm: add more blk plug
Date: Mon, 26 Sep 2011 05:45:54 -0400 [thread overview]
Message-ID: <20110926094554.GA30827@infradead.org> (raw)
In-Reply-To: <1317022727.29510.175.camel@sli10-conroe>
On Mon, Sep 26, 2011 at 03:38:47PM +0800, Shaohua Li wrote:
> On Mon, 2011-09-26 at 15:30 +0800, Christoph Hellwig wrote:
> > On Mon, Sep 26, 2011 at 10:30:26AM +0800, Shaohua Li wrote:
> > > Some filesystems implement .writepages. We don't have blk plug
> > > in such filesystems for .writepages.
> >
> > Please add the plugging in the actual ->writepages instances.
> there are several filesystems have ->writepages. Can you share an hint
> why we don't add plugging in the do_writepages?
Because do_writepages is completely generic code with no knowledge of
block I/O. I really don't want to have block plugging be intimately
tied into core VM/writeback code all over. We've been there with
->sync_page, and it was a major pain - nevermind the additional (small)
overhead for the not block based filesystems.
next prev parent reply other threads:[~2011-09-26 9:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-26 2:30 [patch]mm: add more blk plug Shaohua Li
2011-09-26 7:30 ` Christoph Hellwig
2011-09-26 7:38 ` Shaohua Li
2011-09-26 9:45 ` Christoph Hellwig [this message]
2011-09-28 3:09 ` [patch]ext4: add block plug for .writepages Shaohua Li
2011-10-09 6:09 ` Shaohua Li
2011-10-10 16:51 ` Ted Ts'o
2011-10-11 0:07 ` NamJae Jeon
2011-10-11 10:40 ` Kyungmin Park
2011-10-12 0:53 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110926094554.GA30827@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).