From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753149Ab1IZT5M (ORCPT ); Mon, 26 Sep 2011 15:57:12 -0400 Received: from mail-wy0-f174.google.com ([74.125.82.174]:55469 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752908Ab1IZT5J (ORCPT ); Mon, 26 Sep 2011 15:57:09 -0400 Date: Mon, 26 Sep 2011 20:57:04 +0100 From: Jamie Iles To: Rob Herring Cc: linux-arm-kernel@lists.infradead.org, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, grant.likely@secretlab.ca, marc.zyngier@arm.com, thomas.abraham@linaro.org, jamie@jamieiles.com, b-cousson@ti.com, shawn.guo@linaro.org, dave.martin@linaro.org, linux@arm.linux.org.uk, Rob Herring Subject: Re: [PATCH 3/3] ARM: gic: add OF based initialization Message-ID: <20110926195704.GD9194@gallagher> References: <1316550244-3655-1-git-send-email-robherring2@gmail.com> <1316550244-3655-4-git-send-email-robherring2@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1316550244-3655-4-git-send-email-robherring2@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, On Tue, Sep 20, 2011 at 03:24:04PM -0500, Rob Herring wrote: [...] > +int __init gic_of_init(struct device_node *node, struct device_node *parent) > +{ > + void __iomem *cpu_base; > + void __iomem *dist_base; > + int irq; > + struct irq_domain *domain = &gic_data[gic_cnt].domain; > + > + if (WARN_ON(!node)) > + return -ENODEV; > + > + dist_base = of_iomap(node, 0); > + WARN(!dist_base, "unable to map gic dist registers\n"); > + > + cpu_base = of_iomap(node, 1); > + WARN(!cpu_base, "unable to map gic cpu registers\n"); > + > + domain->nr_irq = gic_irq_count(dist_base); > + /* subtract off SGIs. Also subtract off PPIs for secondary GICs */ > + if (parent) > + domain->nr_irq -= 32; > + else > + domain->nr_irq -= 16; > + > + domain->irq_base = irq_alloc_descs(-1, 16, domain->nr_irq, numa_node_id()); The way I understand irq_alloc_descs() (probably not very well) is that having the irq parameter < 0 and the from parameter 16 means that it needs to find domain->nr_irq descs starting from at least 16. But if the base is greater than 16, does this still work with the gic entry macros as they are? Jamie