From: Greg KH <greg@kroah.com>
To: Serge Hallyn <serge.hallyn@canonical.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
"Serge E. Hallyn" <serge@hallyn.com>,
Oleg Nesterov <oleg@redhat.com>,
lkml <linux-kernel@vger.kernel.org>,
richard@nod.at, Andrew Morton <akpm@linux-foundation.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Tejun Heo <tj@kernel.org>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 2/2] user namespace: usb: make usb urbs user namespace aware (v2)
Date: Mon, 26 Sep 2011 16:45:40 -0700 [thread overview]
Message-ID: <20110926234540.GA28525@kroah.com> (raw)
In-Reply-To: <20110926154518.GA6897@peqn>
On Mon, Sep 26, 2011 at 10:45:18AM -0500, Serge Hallyn wrote:
> Add to the dev_state and alloc_async structures the user namespace
> corresponding to the uid and euid. Pass these to kill_pid_info_as_uid(),
> which can then implement a proper, user-namespace-aware uid check.
>
> Changelog:
> Sep 20: Per Oleg's suggestion: Instead of caching and passing user namespace,
> uid, and euid each separately, pass a struct cred.
> Sep 26: Address Alan Stern's comments: don't define a struct cred at
> usbdev_open(), and take and put a cred at async_completed() to
> ensure it lasts for the duration of kill_pid_info_as_cred().
>
> Signed-off-by: Serge Hallyn <serge.hallyn@canonical.com>
> Cc: Greg KH <greg@kroah.com>
I have no objection to this, is it going to go through your tree, or
somewhere else?
If so, please add:
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
to it.
greg k-h
next prev parent reply other threads:[~2011-09-26 23:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-26 15:18 [PATCH] pid_ns: ensure pid is not freed during kill_pid_info_as_uid Serge Hallyn
2011-09-26 15:45 ` [PATCH 2/2] user namespace: usb: make usb urbs user namespace aware (v2) Serge Hallyn
2011-09-26 23:45 ` Greg KH [this message]
2011-09-27 12:41 ` Serge E. Hallyn
2011-09-27 14:56 ` Greg KH
2011-09-27 15:18 ` Serge Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110926234540.GA28525@kroah.com \
--to=greg@kroah.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=richard@nod.at \
--cc=serge.hallyn@canonical.com \
--cc=serge@hallyn.com \
--cc=stern@rowland.harvard.edu \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox