From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752873Ab1I0JeX (ORCPT ); Tue, 27 Sep 2011 05:34:23 -0400 Received: from zimbra.linbit.com ([212.69.161.123]:53571 "EHLO zimbra.linbit.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752381Ab1I0JeV (ORCPT ); Tue, 27 Sep 2011 05:34:21 -0400 From: Philipp Reisner Organization: LINBIT To: Kyle Moffett Subject: Re: [PATCH 07/10] drbd: Remove headers from on-the-wire data structures (struct p_*) Date: Tue, 27 Sep 2011 11:34:03 +0200 User-Agent: KMail/1.13.6 (Linux/2.6.38-8-generic; KDE/4.6.2; i686; ; ) Cc: linux-kernel@vger.kernel.org, Jens Axboe , drbd-dev@lists.linbit.com References: <1316788285-17433-1-git-send-email-philipp.reisner@linbit.com> <1316788285-17433-8-git-send-email-philipp.reisner@linbit.com> In-Reply-To: X-OTRS-FollowUp-SenderType: agent MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201109271134.03529.philipp.reisner@linbit.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Freitag, 23. September 2011, 19:38:15 schrieb Kyle Moffett: > Hi! > > On Fri, Sep 23, 2011 at 10:31, Philipp Reisner > > wrote: > > From: Andreas Gruenbacher > > > > Signed-off-by: Philipp Reisner > > Signed-off-by: Lars Ellenberg > > --- > > drivers/block/drbd/drbd_int.h | 45 ---------- > > drivers/block/drbd/drbd_main.c | 44 +++++----- > > drivers/block/drbd/drbd_receiver.c | 171 > > ++++++++++++++++++------------------ drivers/block/drbd/drbd_worker.c > > | 2 +- > > This commit is kind of borderline too-big for just a one-line commit > message. > > It is admittedly very simple (changing the same pointer math in ~50 > places), but it needs a bit more explanation about why it's helpful or > necessary. > > I *think* it's because the protocol-100 code will use a different-sized > header, but that needs to be actually explained somewhere. > I updated the patch to carry the following commit message: Author: Andreas Gruenbacher Date: Wed Mar 30 12:54:42 2011 +0200 drbd: Remove headers from on-the-wire data structures (struct p_*) Prepare the introduction of the protocol 100 headers. The actual protocol header is removed for the packet declarations. I.e. allow us to use the packets with different headers. Signed-off-by: Philipp Reisner Signed-off-by: Lars Ellenberg Best, Phil -- : Dipl-Ing Philipp Reisner : LINBIT | Your Way to High Availability : Tel: +43-1-8178292-50, Fax: +43-1-8178292-82 : http://www.linbit.com DRBD(R) and LINBIT(R) are registered trademarks of LINBIT, Austria.