From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754028Ab1I0MmJ (ORCPT <rfc822;w@1wt.eu>);
	Tue, 27 Sep 2011 08:42:09 -0400
Received: from youngberry.canonical.com ([91.189.89.112]:53241 "EHLO
	youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753345Ab1I0MmH (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 27 Sep 2011 08:42:07 -0400
Date: Tue, 27 Sep 2011 07:41:57 -0500
From: "Serge E. Hallyn" <serge.hallyn@canonical.com>
To: Greg KH <greg@kroah.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
        "Serge E. Hallyn" <serge@hallyn.com>, Oleg Nesterov <oleg@redhat.com>,
        lkml <linux-kernel@vger.kernel.org>, richard@nod.at,
        Andrew Morton <akpm@linux-foundation.org>,
        "Eric W. Biederman" <ebiederm@xmission.com>, Tejun Heo <tj@kernel.org>,
        linux-usb@vger.kernel.org
Subject: Re: [PATCH 2/2] user namespace: usb: make usb urbs user namespace
 aware (v2)
Message-ID: <20110927124156.GA3111@sergelap>
References: <20110926151829.GA5190@peqn>
 <20110926154518.GA6897@peqn>
 <20110926234540.GA28525@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110926234540.GA28525@kroah.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Quoting Greg KH (greg@kroah.com):
> On Mon, Sep 26, 2011 at 10:45:18AM -0500, Serge Hallyn wrote:
> > Add to the dev_state and alloc_async structures the user namespace
> > corresponding to the uid and euid.  Pass these to kill_pid_info_as_uid(),
> > which can then implement a proper, user-namespace-aware uid check.
> > 
> > Changelog:
> > Sep 20: Per Oleg's suggestion: Instead of caching and passing user namespace,
> > 	uid, and euid each separately, pass a struct cred.
> > Sep 26: Address Alan Stern's comments: don't define a struct cred at
> > 	usbdev_open(), and take and put a cred at async_completed() to
> > 	ensure it lasts for the duration of kill_pid_info_as_cred().
> > 
> > Signed-off-by: Serge Hallyn <serge.hallyn@canonical.com>
> > Cc: Greg KH <greg@kroah.com>
> 
> I have no objection to this, is it going to go through your tree, or
> somewhere else?

(Silly question from me, but just to make sure - were you asking this of
Alan?)

> If so, please add:
> 	Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
> to it.

Thanks,
-serge