From: Serge Hallyn <serge.hallyn@canonical.com>
To: Greg KH <greg@kroah.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
"Serge E. Hallyn" <serge@hallyn.com>,
Oleg Nesterov <oleg@redhat.com>,
lkml <linux-kernel@vger.kernel.org>,
richard@nod.at, Andrew Morton <akpm@linux-foundation.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Tejun Heo <tj@kernel.org>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 2/2] user namespace: usb: make usb urbs user namespace aware (v2)
Date: Tue, 27 Sep 2011 10:18:59 -0500 [thread overview]
Message-ID: <20110927151859.GA2952@peqn> (raw)
In-Reply-To: <20110927145605.GB17524@kroah.com>
Quoting Greg KH (greg@kroah.com):
> On Tue, Sep 27, 2011 at 07:41:57AM -0500, Serge E. Hallyn wrote:
> > Quoting Greg KH (greg@kroah.com):
> > > On Mon, Sep 26, 2011 at 10:45:18AM -0500, Serge Hallyn wrote:
> > > > Add to the dev_state and alloc_async structures the user namespace
> > > > corresponding to the uid and euid. Pass these to kill_pid_info_as_uid(),
> > > > which can then implement a proper, user-namespace-aware uid check.
> > > >
> > > > Changelog:
> > > > Sep 20: Per Oleg's suggestion: Instead of caching and passing user namespace,
> > > > uid, and euid each separately, pass a struct cred.
> > > > Sep 26: Address Alan Stern's comments: don't define a struct cred at
> > > > usbdev_open(), and take and put a cred at async_completed() to
> > > > ensure it lasts for the duration of kill_pid_info_as_cred().
> > > >
> > > > Signed-off-by: Serge Hallyn <serge.hallyn@canonical.com>
> > > > Cc: Greg KH <greg@kroah.com>
> > >
> > > I have no objection to this, is it going to go through your tree, or
> > > somewhere else?
> >
> > (Silly question from me, but just to make sure - were you asking this of
> > Alan?)
>
> Nope, you. Do you have a tree for this type of namespace work? I
> haven't been paying attention to it at all.
No, at the moment I don't.
> If not, I'll gladly take it myself, I just don't want to cause any merge
> conflicts anywhere else if at all possible.
Great, thanks.
-serge
prev parent reply other threads:[~2011-09-27 15:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-26 15:18 [PATCH] pid_ns: ensure pid is not freed during kill_pid_info_as_uid Serge Hallyn
2011-09-26 15:45 ` [PATCH 2/2] user namespace: usb: make usb urbs user namespace aware (v2) Serge Hallyn
2011-09-26 23:45 ` Greg KH
2011-09-27 12:41 ` Serge E. Hallyn
2011-09-27 14:56 ` Greg KH
2011-09-27 15:18 ` Serge Hallyn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110927151859.GA2952@peqn \
--to=serge.hallyn@canonical.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=richard@nod.at \
--cc=serge@hallyn.com \
--cc=stern@rowland.harvard.edu \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox