From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752936Ab1I0Sik (ORCPT ); Tue, 27 Sep 2011 14:38:40 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:37975 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752258Ab1I0Sij (ORCPT ); Tue, 27 Sep 2011 14:38:39 -0400 Date: Tue, 27 Sep 2011 19:38:32 +0100 From: Mark Brown To: Daniel Drake Cc: Grant Likely , sameo@linux.intel.com, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, dilinger@queued.net Subject: Re: [PATCH 1/3] mfd: allow mfd_cell association with device tree node Message-ID: <20110927183832.GS4289@opensource.wolfsonmicro.com> References: <20110921124936.GA25620@sirena.org.uk> <20110921131637.GF4374@opensource.wolfsonmicro.com> <20110927150555.GF20588@ponder.secretlab.ca> <20110927181420.GQ4289@opensource.wolfsonmicro.com> <20110927182636.GR4289@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Cookie: You will outgrow your usefulness. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 27, 2011 at 07:28:40PM +0100, Daniel Drake wrote: > On Tue, Sep 27, 2011 at 7:26 PM, Mark Brown > > That seems like a bug that just happened to get noticed while reviewing > > this change, though... > Sorry if I'm missing something obvious but I'm not seeing the issue. > What exactly is this bug and what effects could it cause? You're modifying global data which should really be const and is shared between multiple devices in place. Probably you'll not notice any practical effects, especially if you don't happen to have multiple devices in the same system.