From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753145Ab1I0TPJ (ORCPT ); Tue, 27 Sep 2011 15:15:09 -0400 Received: from mail-bw0-f46.google.com ([209.85.214.46]:51529 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751678Ab1I0TPI (ORCPT ); Tue, 27 Sep 2011 15:15:08 -0400 Date: Tue, 27 Sep 2011 23:14:13 +0400 From: Vasiliy Kulikov To: David Rientjes Cc: kernel-hardening@lists.openwall.com, Christoph Lameter , Pekka Enberg , Matt Mackall , Andrew Morton , linux-mm@kvack.org, Kees Cook , Dave Hansen , Valdis.Kletnieks@vt.edu, Linus Torvalds , Alan Cox , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mm: restrict access to /proc/meminfo Message-ID: <20110927191413.GA4820@albatros> References: <20110927175453.GA3393@albatros> <20110927175642.GA3432@albatros> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 27, 2011 at 11:27 -0700, David Rientjes wrote: > On Tue, 27 Sep 2011, Vasiliy Kulikov wrote: > > > /proc/meminfo stores information related to memory pages usage, which > > may be used to monitor the number of objects in specific caches (and/or > > the changes of these numbers). This might reveal private information > > similar to /proc/slabinfo infoleaks. To remove the infoleak, just > > restrict meminfo to root. If it is used by unprivileged daemons, > > meminfo permissions can be altered the same way as slabinfo: > > > > groupadd meminfo > > usermod -a -G meminfo $MONITOR_USER > > chmod g+r /proc/meminfo > > chgrp meminfo /proc/meminfo > > > > I guess the side-effect of this is that users without root will no longer > report VM issues where "there's tons of freeable memory but my task got > killed", "there's swap available but is unutilized in lowmem situations", > etc. :) Uhh, lost of "free" is rather significant. > Seriously, though, can't we just change the granularity of /proc/meminfo > to be MB instead of KB or at least provide a separate file that is > readable that does that? I can understand not exporting information on a > page-level granularity but not giving users a way to determine the amount > of free memory is a little extreme. Probably it is the way to go. Users still may identify *some* information about the slab objects in question (ecryptfs, etc.), but it is more limited with MB granularity. Though, it is probably the only acceptable tradeoff in sense of backward compatibility. Thank you, -- Vasiliy Kulikov http://www.openwall.com - bringing security into open computing environments