From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Daniel Drake <dsd@laptop.org>
Cc: Grant Likely <grant.likely@secretlab.ca>,
sameo@linux.intel.com, devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, dilinger@queued.net
Subject: Re: [PATCH 1/3] mfd: allow mfd_cell association with device tree node
Date: Wed, 28 Sep 2011 13:31:55 +0100 [thread overview]
Message-ID: <20110928123154.GG3279@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAMLZHHRvr-diYGwZ2Kg647Ht7NNb8LEku0pCW8EujRuUeOW5yQ@mail.gmail.com>
On Wed, Sep 28, 2011 at 10:07:43AM +0100, Daniel Drake wrote:
> On Tue, Sep 27, 2011 at 7:38 PM, Mark Brown
> > You're modifying global data which should really be const and is shared
> > between multiple devices in place. Probably you'll not notice any
> > practical effects, especially if you don't happen to have multiple
> > devices in the same system.
> I see. In this case, it would be impossible to have two VX855s in the
> same system, and if you did, you would have bigger problems. In this
> context what we're doing is safe.
Right, but your modification was to the MFD core so it's going to affect
other devices...
next prev parent reply other threads:[~2011-09-28 12:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-21 12:01 [PATCH 1/3] mfd: allow mfd_cell association with device tree node Daniel Drake
2011-09-21 12:49 ` Mark Brown
2011-09-21 13:02 ` Daniel Drake
2011-09-21 13:16 ` Mark Brown
2011-09-27 14:44 ` Daniel Drake
2011-09-27 15:05 ` Grant Likely
2011-09-27 15:18 ` Mark Brown
2011-09-27 16:44 ` Daniel Drake
2011-09-27 18:14 ` Mark Brown
2011-09-27 18:25 ` Daniel Drake
2011-09-27 18:26 ` Mark Brown
2011-09-27 18:28 ` Daniel Drake
2011-09-27 18:38 ` Mark Brown
2011-09-28 9:07 ` Daniel Drake
2011-09-28 12:31 ` Mark Brown [this message]
2011-10-03 8:40 ` Daniel Drake
2011-10-03 10:28 ` Mark Brown
2011-10-03 10:39 ` Daniel Drake
2011-10-03 12:16 ` Mark Brown
2011-10-03 12:30 ` Daniel Drake
2011-10-03 12:40 ` Mark Brown
2011-10-03 12:53 ` Daniel Drake
-- strict thread matches above, loose matches on Subject: below --
2011-09-28 9:08 Daniel Drake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110928123154.GG3279@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dilinger@queued.net \
--cc=dsd@laptop.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).