public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Jan Beulich <JBeulich@suse.com>
Cc: tglx@linutronix.de, hpa@zytor.com,
	Frederic Weisbecker <fweisbec@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH, resend] x86-64: fix CFI data for interrupt frames
Date: Wed, 28 Sep 2011 18:59:18 +0200	[thread overview]
Message-ID: <20110928165917.GC10084@elte.hu> (raw)
In-Reply-To: <4E8360200200007800058467@nat28.tlf.novell.com>


* Jan Beulich <JBeulich@suse.com> wrote:

> The patch titled "x86: Don't use frame pointer to save old stack on irq
> entry" did not properly adjust CFI directives, so this patch is a
> follow-up to that one.
> 
> With the old stack pointer no longer stored in a callee-saved register
> (plus some offset), we now have to use a CFA expression to describe the
> memory location where it is being found. This requires the use of
> .cfi_escape (allowing arbitrary byte streams to be emitted into
> .eh_frame), as there is no .cfi_def_cfa_expression (which also cannot
> reasonably be expected, as it would require a full expression parser).
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> 
> ---
>  arch/x86/include/asm/dwarf2.h |    2 ++
>  arch/x86/kernel/entry_64.S    |   14 +++++++++-----
>  2 files changed, 11 insertions(+), 5 deletions(-)

Applied all 3 patches you sent, thanks Jan! (the tip-bot notification 
depends on korg being fully restored.)

Thanks,

	Ingo

      reply	other threads:[~2011-09-28 17:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-28 15:57 [PATCH, resend] x86-64: fix CFI data for interrupt frames Jan Beulich
2011-09-28 16:59 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110928165917.GC10084@elte.hu \
    --to=mingo@elte.hu \
    --cc=JBeulich@suse.com \
    --cc=fweisbec@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox