Re: [PATCH] Fix repeatable Oops on container destroy with conntrack

Pablo Neira Ayuso
2011-09-14T01:35:07Z

On Tue, Sep 13, 2011 at 09:44:38PM +0100, Alex Bligh wrote:
> Alexey / Pablo,
>
> --On 12 September 2011 20:06:25 +0100 Alex Bligh <alex@alex.org.uk> wrote:
>
> >Pablo,
> >
> >--On 12 September 2011 20:33:57 +0200 Pablo Neira Ayuso
> ><pablo@netfilter.org> wrote:
> >
> >>Yes, this is what Alexey was pointing out in the previous email and
> >>why he suggested to move it to nfnetlink_has_listeners (to cover the
> >>expectation case).
> >>
> >>But you're right, we cannot move it to nfnetlink_has_listeners because
> >>of the item->report case. Please, include the expectation part and
> >>resend the patch.
> >
> >Thanks - see below
>
> Is this new version OK? I am happy to adjust if not.

Hm, I still think that this is a workaround.

The nice fix should move nf_conntrack_event_cb in
nf_conntrack_ecache.c to the net container structure.

Alexey?

> I think we ought to get /something/ in, because without anything it's
> very simple to cause an oops and a resultant machine hang.

Sure, I'm all for fixing it :-).