linux-next: build failure after merge of the pm tree

Stephen Rothwell
2025-03-12T12:58:33Z

[-- Attachment #1: Type: text/plain, Size: 1939 bytes --]

Hi all,

After merging the pm tree, today's linux-next build (powerpc allyesconfig)
failed like this:

drivers/pinctrl/pinctrl-amd.c:933:15: error: variable 'pinctrl_amd_s2idle_dev_ops' has initializer but incomplete type
933 | static struct acpi_s2idle_dev_ops pinctrl_amd_s2idle_dev_ops = {
| ^~~~~~~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-amd.c:934:10: error: 'struct acpi_s2idle_dev_ops' has no member named 'check'
934 | .check = amd_gpio_check_pending,
| ^~~~~
drivers/pinctrl/pinctrl-amd.c:934:18: error: excess elements in struct initializer [-Werror]
934 | .check = amd_gpio_check_pending,
| ^~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-amd.c:934:18: note: (near initialization for 'pinctrl_amd_s2idle_dev_ops')
drivers/pinctrl/pinctrl-amd.c: In function 'amd_gpio_probe':
drivers/pinctrl/pinctrl-amd.c:1210:9: error: implicit declaration of function 'acpi_register_lps0_dev' [-Wimplicit-function-declaration]
1210 | acpi_register_lps0_dev(&pinctrl_amd_s2idle_dev_ops);
| ^~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-amd.c: In function 'amd_gpio_remove':
drivers/pinctrl/pinctrl-amd.c:1229:9: error: implicit declaration of function 'acpi_unregister_lps0_dev' [-Wimplicit-function-declaration]
1229 | acpi_unregister_lps0_dev(&pinctrl_amd_s2idle_dev_ops);
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-amd.c: At top level:
drivers/pinctrl/pinctrl-amd.c:933:35: error: storage size of 'pinctrl_amd_s2idle_dev_ops' isn't known
933 | static struct acpi_s2idle_dev_ops pinctrl_amd_s2idle_dev_ops = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

Caused by commit

a62f03d037cc ("pinctrl: amd: Add an LPS0 check() callback")

I have reverted that commit for today.

--
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]