Re: [PATCH] backlight: Rename corgibl_limit_intensity to genericbl_limit_intensity

Richard Purdie
2011-09-29T20:22:24Z

On Thu, 2011-09-29 at 13:00 -0700, Andrew Morton wrote:
> On Sun, 25 Sep 2011 10:12:33 +0800
> Axel Lin <axel.lin@gmail.com> wrote:
>
> > The rename of corgibl_limit_intensity is missed in commit d00ba726
> > "backlight: Rename the corgi backlight driver to generic".
> > Let's fix it now.
> >
> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
> > Cc: Richard Purdie <rpurdie@rpsys.net>
> > ---
> > drivers/video/backlight/generic_bl.c | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/video/backlight/generic_bl.c b/drivers/video/backlight/generic_bl.c
> > index 8c6befd..adb1914 100644
> > --- a/drivers/video/backlight/generic_bl.c
> > +++ b/drivers/video/backlight/generic_bl.c
> > @@ -56,7 +56,7 @@ static int genericbl_get_intensity(struct backlight_device *bd)
> > * Called when the battery is low to limit the backlight intensity.
> > * If limit==0 clear any limit, otherwise limit the intensity
> > */
> > -void corgibl_limit_intensity(int limit)
> > +void genericbl_limit_intensity(int limit)
> > {
> > struct backlight_device *bd = generic_backlight_device;
> >
> > @@ -68,7 +68,7 @@ void corgibl_limit_intensity(int limit)
> > backlight_update_status(generic_backlight_device);
> > mutex_unlock(&bd->ops_lock);
> > }
> > -EXPORT_SYMBOL(corgibl_limit_intensity);
> > +EXPORT_SYMBOL(genericbl_limit_intensity);
> >
>
> Why does corgibl_limit_intensity/genericbl_limit_intensity exist?
> Nothing in the tree references it?

It sounds like someone has removed the sharpsl battery driver which did
use this. If this hook isn't used, low battery with high screen
backlight values will reset the device as the wiring isn't up to the
current draw.

Richard