From: Andrew Morton <akpm00@gmail.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
viro@zeniv.linux.org.uk,
"Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] Clean up brlocks/lglocks
Date: Thu, 29 Sep 2011 15:36:18 -0700 [thread overview]
Message-ID: <20110929153618.c761d9bb.akpm00@gmail.com> (raw)
In-Reply-To: <1317252644-5146-1-git-send-email-andi@firstfloor.org>
On Wed, 28 Sep 2011 16:30:44 -0700
Andi Kleen <andi@firstfloor.org> wrote:
> lglocks and brlocks are currently generated with some complicated macros
> in lglock.h. But there's no reason, I can see, to not just use common
> utility functions that get pointers to the lglock.
https://lkml.org/lkml/2011/8/24/454 makes me suspect that there's a bug
in brlocks, or they're being misused in some way. However the code
doesn't have an identifiable maintainer, so things just sit there.
I guess these problems don't preclude cosmetic cleanups, but it's all a
bit regrettable.
prev parent reply other threads:[~2011-09-29 22:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-28 23:30 [PATCH] Clean up brlocks/lglocks Andi Kleen
2011-09-29 22:36 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110929153618.c761d9bb.akpm00@gmail.com \
--to=akpm00@gmail.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox