From: Al Viro <viro@ZenIV.linux.org.uk>
To: Josh Boyer <jwboyer@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v3] fs/minix: Verify bitmap block counts before mounting
Date: Thu, 29 Sep 2011 19:51:32 +0100 [thread overview]
Message-ID: <20110929185132.GM2203@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20110929183818.GI16720@zod.bos.redhat.com>
On Thu, Sep 29, 2011 at 02:38:18PM -0400, Josh Boyer wrote:
> On Fri, Aug 19, 2011 at 02:50:25PM -0400, Josh Boyer wrote:
> > Newer versions of MINIX can create filesystems that allocate an extra
> > bitmap block. Mounting of this succeeds, but doing a statfs call will
> > result in an oops in count_free because of a negative number being used
> > for the bh index.
> >
> > Avoid this by verifying the number of allocated blocks at mount time,
> > erroring out if there are not enough and make statfs ignore the extras
> > if there are too many.
> >
> > This fixes https://bugzilla.kernel.org/show_bug.cgi?id=18792
> >
> > Signed-off-by: Josh Boyer <jwboyer@redhat.com>
>
> Al, did this ever get queued up to send to Linus?
Sits in my tree, waiting for kernel.org to come back, with obvious
followup on top of it...
commit 2a0b3282ff528af4c0824c16d99c62a53d029720
Author: Al Viro <viro@zeniv.linux.org.uk>
Date: Fri Aug 26 22:38:50 2011 -0400
minixfs: kill manual hweight(), simplify
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
commit b928f2ccce51ffd666e4238e8c166dfeb0069c28
Author: Josh Boyer <jwboyer@redhat.com>
Date: Fri Aug 19 14:50:26 2011 -0400
fs/minix: Verify bitmap block counts before mounting
prev parent reply other threads:[~2011-09-29 18:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-19 18:50 [PATCH v3] fs/minix: Verify bitmap block counts before mounting Josh Boyer
2011-09-29 18:38 ` Josh Boyer
2011-09-29 18:51 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110929185132.GM2203@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=jwboyer@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox