Re: [PATCH v3] fs/minix: Verify bitmap block counts before mounting

Al Viro
2011-09-29T18:51:35Z

On Thu, Sep 29, 2011 at 02:38:18PM -0400, Josh Boyer wrote:
> On Fri, Aug 19, 2011 at 02:50:25PM -0400, Josh Boyer wrote:
> > Newer versions of MINIX can create filesystems that allocate an extra
> > bitmap block. Mounting of this succeeds, but doing a statfs call will
> > result in an oops in count_free because of a negative number being used
> > for the bh index.
> >
> > Avoid this by verifying the number of allocated blocks at mount time,
> > erroring out if there are not enough and make statfs ignore the extras
> > if there are too many.
> >
> > This fixes https://bugzilla.kernel.org/show_bug.cgi?id=18792
> >
> > Signed-off-by: Josh Boyer <jwboyer@redhat.com>
>
> Al, did this ever get queued up to send to Linus?

Sits in my tree, waiting for kernel.org to come back, with obvious
followup on top of it...

commit 2a0b3282ff528af4c0824c16d99c62a53d029720
Author: Al Viro <viro@zeniv.linux.org.uk>
Date: Fri Aug 26 22:38:50 2011 -0400

minixfs: kill manual hweight(), simplify

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

commit b928f2ccce51ffd666e4238e8c166dfeb0069c28
Author: Josh Boyer <jwboyer@redhat.com>
Date: Fri Aug 19 14:50:26 2011 -0400

fs/minix: Verify bitmap block counts before mounting