From: Adrian Bunk <bunk@stusta.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
Josh Triplett <josh@joshtriplett.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>
Subject: Please revert "debug: Make CONFIG_EXPERT select CONFIG_DEBUG_KERNEL to unhide debug options"
Date: Fri, 30 Sep 2011 16:42:45 +0300 [thread overview]
Message-ID: <20110930134245.GB21474@localhost.pp.htv.fi> (raw)
I was just wondering why I was asked about all the debug options when I
tried 3.1-rc8, and that was due to commit f505c553 (debug: Make
CONFIG_EXPERT select CONFIG_DEBUG_KERNEL to unhide debug options),
the full commit is below.
It is wrong, and the author does not seem to understand how Kconfig works.
The commit message is:
Several debugging options currently default to y, such as
CONFIG_DEBUG_BUGVERBOSE and CONFIG_DEBUG_RODATA. Embedded users
might want to turn those options off to save space; however,
turning them off requires turning on CONFIG_DEBUG_KERNEL to
unhide them. Since CONFIG_DEBUG_KERNEL exists specifically to
unhide debugging options, and CONFIG_EXPERT exists specifically
to unhide options potentially needed by experts and/or embedded
users, make CONFIG_EXPERT automatically imply
CONFIG_DEBUG_KERNEL.
Let me point at the obvious fact that both CONFIG_DEBUG_BUGVERBOSE and
CONFIG_DEBUG_RODATA do depend on DEBUG_KERNEL, and are contrary to the
claim of the author of this patch never enabled with
CONFIG_DEBUG_KERNEL=n. [1]
Linus, please revert this commit.
Thanks
Adrian
[1] Select abuse would be an exception, but that doesn't seem to be
the case for these options.
next reply other threads:[~2011-09-30 13:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 13:42 Adrian Bunk [this message]
2011-09-30 15:05 ` Please revert "debug: Make CONFIG_EXPERT select CONFIG_DEBUG_KERNEL to unhide debug options" Josh Triplett
2011-09-30 15:25 ` Frederic Weisbecker
2011-09-30 15:32 ` Frederic Weisbecker
2011-09-30 15:54 ` Adrian Bunk
2011-09-30 15:50 ` Adrian Bunk
2011-10-10 7:29 ` Ingo Molnar
2011-10-10 8:48 ` Adrian Bunk
2011-10-10 9:44 ` Mike Galbraith
2011-10-10 10:21 ` Ingo Molnar
2011-10-10 12:13 ` Adrian Bunk
2011-10-12 8:38 ` Ingo Molnar
2011-10-20 21:41 ` Adrian Bunk
2011-10-21 8:19 ` Michal Marek
2011-10-21 9:22 ` Adrian Bunk
2011-10-21 12:37 ` Michal Marek
2011-10-21 16:12 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110930134245.GB21474@localhost.pp.htv.fi \
--to=bunk@stusta.de \
--cc=fweisbec@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox