From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756819Ab1I3Rwx (ORCPT ); Fri, 30 Sep 2011 13:52:53 -0400 Received: from cantor2.suse.de ([195.135.220.15]:52481 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753119Ab1I3Rww (ORCPT ); Fri, 30 Sep 2011 13:52:52 -0400 Date: Fri, 30 Sep 2011 10:49:17 -0700 From: Greg KH To: Felipe Balbi Cc: Sebastian Andrzej Siewior , Sarah Sharp , linux-usb@vger.kernel.org, Grant Likely , linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/20] drivers_base: platform: use always ->name for uevent Message-ID: <20110930174917.GA17827@suse.de> References: <1313419901-13492-1-git-send-email-bigeasy@linutronix.de> <1313419901-13492-2-git-send-email-bigeasy@linutronix.de> <20110930132914.GA877@legolas.emea.dhcp.ti.com> <20110930170914.GA15341@suse.de> <20110930174000.GB4163@legolas.emea.dhcp.ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110930174000.GB4163@legolas.emea.dhcp.ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 30, 2011 at 08:40:02PM +0300, Felipe Balbi wrote: > Hi, > > On Fri, Sep 30, 2011 at 10:09:14AM -0700, Greg KH wrote: > > On Fri, Sep 30, 2011 at 04:29:16PM +0300, Felipe Balbi wrote: > > > Hi, > > > > > > On Mon, Aug 15, 2011 at 04:51:22PM +0200, Sebastian Andrzej Siewior wrote: > > > > If id_entry is available then it is used. However if we remove first the > > > > driver followed by the device, then the id_entry is pointing to driver's > > > > memory which is long gone. > > > > Since id->name and plat->name are equal there is no point in > > > > distinguishing them. > > > > > > > > Cc: Greg Kroah-Hartman > > > > Cc: Grant Likely > > > > Cc: linux-kernel@vger.kernel.org > > > > Signed-off-by: Sebastian Andrzej Siewior > > > > --- > > > > drivers/base/platform.c | 2 +- > > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > > > diff --git a/drivers/base/platform.c b/drivers/base/platform.c > > > > index 0cad9c7..cd71575 100644 > > > > --- a/drivers/base/platform.c > > > > +++ b/drivers/base/platform.c > > > > @@ -614,7 +614,7 @@ static int platform_uevent(struct device *dev, struct kobj_uevent_env *env) > > > > return rc; > > > > > > > > add_uevent_var(env, "MODALIAS=%s%s", PLATFORM_MODULE_PREFIX, > > > > - (pdev->id_entry) ? pdev->id_entry->name : pdev->name); > > > > + pdev->name); > > > > return 0; > > > > } > > > > > > > > > > Just a gentle reminder on this patch. Greg, has this one been queued to > > > your drivers-core tree ? Should it go on -rc or now it's already too > > > late and going on merge window ? > > > > It's been in my drivers-core tree for a while, and I didn't think it was > > needed for 3.1, as it didn't solve an existing bug, did it? > > > > It's queued for 3.2, does it need to get into 3.1-stable? If so, I can > > do that. > > I don't think it's needed. Just make sure drivers-core is merged before > your USB tree :-) Ok, will do, I forgot about that restriction, thanks for reminding me. greg k-h