From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758552Ab1JAAJT (ORCPT ); Fri, 30 Sep 2011 20:09:19 -0400 Received: from e9.ny.us.ibm.com ([32.97.182.139]:48333 "EHLO e9.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755383Ab1JAAJC (ORCPT ); Fri, 30 Sep 2011 20:09:02 -0400 Subject: [RFCv3][PATCH 3/4] add seq_print_pow2() function To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, rientjes@google.com, James.Bottomley@HansenPartnership.com, hpa@zytor.com, Dave Hansen From: Dave Hansen Date: Fri, 30 Sep 2011 17:08:58 -0700 References: <20111001000856.DD623081@kernel> In-Reply-To: <20111001000856.DD623081@kernel> Message-Id: <20111001000858.D1CD9117@kernel> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In order to get nice, human-readable output, we are going to use MiB/KiB, etc... in numa_maps. Introduce a helper to do the conversion from a raw integer over to a string. I thought about doing this as a new printk() format specifier. That would be interesting, but it's hard to argue with this since it's so short and sweet. Signed-off-by: Dave Hansen --- linux-2.6.git-dave/fs/seq_file.c | 11 +++++++++++ linux-2.6.git-dave/include/linux/seq_file.h | 2 ++ 2 files changed, 13 insertions(+) diff -puN fs/seq_file.c~add-seq_print_size fs/seq_file.c --- linux-2.6.git/fs/seq_file.c~add-seq_print_size 2011-09-30 16:41:04.169957332 -0700 +++ linux-2.6.git-dave/fs/seq_file.c 2011-09-30 16:41:04.181957311 -0700 @@ -386,6 +386,17 @@ int seq_printf(struct seq_file *m, const } EXPORT_SYMBOL(seq_printf); +/* + * Prints output with KiB/MiB/etc... suffixes + */ +int seq_print_pow2(struct seq_file *seq, u64 size) +{ + u64 shifted_size; + char unit_str[4]; + shifted_size = string_get_size_pow2(size, unit_str); + return seq_printf(seq, "%llu%s", shifted_size, unit_str); +} + /** * mangle_path - mangle and copy path to buffer beginning * @s: buffer start diff -puN include/linux/seq_file.h~add-seq_print_size include/linux/seq_file.h --- linux-2.6.git/include/linux/seq_file.h~add-seq_print_size 2011-09-30 16:41:04.173957325 -0700 +++ linux-2.6.git-dave/include/linux/seq_file.h 2011-09-30 16:41:04.181957311 -0700 @@ -3,6 +3,7 @@ #include #include +#include #include #include #include @@ -83,6 +84,7 @@ int seq_escape(struct seq_file *, const int seq_putc(struct seq_file *m, char c); int seq_puts(struct seq_file *m, const char *s); int seq_write(struct seq_file *seq, const void *data, size_t len); +int seq_print_pow2(struct seq_file *seq, u64 size); int seq_printf(struct seq_file *, const char *, ...) __attribute__ ((format (printf,2,3))); _