From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Cc: gregkh@suse.de, wfp5p@virginia.edu, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/9] Staging: comedi: fix printk issue in cb_pcidas.c
Date: Sat, 1 Oct 2011 18:09:42 +0300 [thread overview]
Message-ID: <20111001150942.GD3901@longonot.mountain> (raw)
In-Reply-To: <1317388707-1980-3-git-send-email-ravishankar.km@greenturtles.in>
On Fri, Sep 30, 2011 at 06:48:21PM +0530, Ravishankar Karkala Mallikarjunayya wrote:
> if (comedi_pci_enable(pcidev, "cb_pcidas")) {
> - printk(" Failed to enable PCI device and request regions\n");
> + dev_err(&pcidev->dev, " Failed to enable PCI "
^
This space isn't needed any more now that it's at the start of a
line.
> + "device and request regions\n");
> return -EIO;
I'm not going to review the remaining 6 patches.
regards,
dan carpenter
next prev parent reply other threads:[~2011-10-01 15:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 13:18 [PATCH 1/9] Staging: comedi: fix printk issue in cb_pcidio.c Ravishankar Karkala Mallikarjunayya
2011-09-30 13:18 ` [PATCH 2/9] Staging: comedi: fix printk issue in cb_pcidda.c Ravishankar Karkala Mallikarjunayya
2011-10-01 15:05 ` Dan Carpenter
2011-09-30 13:18 ` [PATCH 3/9] Staging: comedi: fix printk issue in cb_pcidas.c Ravishankar Karkala Mallikarjunayya
2011-10-01 15:09 ` Dan Carpenter [this message]
2011-10-03 23:30 ` Ryan Mallon
2011-10-04 0:57 ` Joe Perches
2011-09-30 13:18 ` [PATCH 4/9] Staging: comedi: fix printk issue in cb_pcidas64.c Ravishankar Karkala Mallikarjunayya
2011-09-30 13:18 ` [PATCH 5/9] Staging: comedi: fix printk issue in cb_pcimdas.c Ravishankar Karkala Mallikarjunayya
2011-09-30 13:18 ` [PATCH 6/9] Staging: comedi: fix line over 80 character issue in cb_pcidio.c Ravishankar Karkala Mallikarjunayya
2011-09-30 13:18 ` [PATCH 7/9] Staging: comedi: fix line over 80 character issue in cb_pcidda.c Ravishankar Karkala Mallikarjunayya
2011-09-30 13:18 ` [PATCH 8/9] Staging: comedi: fix printk issue in cb_pcidas.c Ravishankar Karkala Mallikarjunayya
2011-09-30 13:18 ` [PATCH 9/9] Staging: comedi: fix line over 80 character " Ravishankar Karkala Mallikarjunayya
2011-10-03 23:27 ` [PATCH 1/9] Staging: comedi: fix printk issue in cb_pcidio.c Ryan Mallon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111001150942.GD3901@longonot.mountain \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ravishankar.km@greenturtles.in \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox