From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mark Einon <mark.einon@gmail.com>
Cc: gregkh@suse.de, devel@driverdev.osuosl.org, alan@linux.intel.com,
linux-kernel@vger.kernel.org, o.hartmann@telovital.com
Subject: Re: [PATCH 7/8] staging: et131x: Updating copyright statements and module authors
Date: Sat, 1 Oct 2011 22:58:35 +0300 [thread overview]
Message-ID: <20111001195835.GA2925@longonot.mountain> (raw)
In-Reply-To: <1317464057-18231-7-git-send-email-mark.einon@gmail.com>
On Sat, Oct 01, 2011 at 11:14:16AM +0100, Mark Einon wrote:
> @@ -945,5 +947,6 @@ module_exit(et131x_cleanup_module);
>
> /* Modinfo parameters (filled out using defines from et131x_version.h) */
> MODULE_AUTHOR(DRIVER_AUTHOR);
> +MODULE_AUTHOR(DRIVER_AUTHOR2);
> MODULE_DESCRIPTION(DRIVER_INFO);
> MODULE_LICENSE(DRIVER_LICENSE);
Both DRIVER_AUTHOR and DRIVER_AUTHOR2 are silly macros. Put the name
in directly. That way you won't need the comment explaining where to
find the definitions. Also normally people use gt lt brackets for
emails:
MODULE_AUTHOR("Victor Soriano <vjsoriano@agere.com>");
MODULE_AUTHOR("Mark Einon <mark.einon@gmail.com>");
Go ahead and fix this in a later patch if you want. All the macros
there should probably be replaced.
Btw, the problems with kernel.org have complicated things here, so
I can't tell if you have already fixed this, but the driver doesn't
compile any more. The Kconfig file says it "depends on NETDEV_1000"
but NETDEV_1000 isn't around any more since f860b0522f65d3
"drivers/net: Kconfig and Makefile cleanup" was merged.
regards,
dan carpenter
next prev parent reply other threads:[~2011-10-01 20:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-01 10:14 [PATCH 1/8] staging: et131x: Remove TODO entry 'alloc_etherdev initilising memory with zero' Mark Einon
2011-10-01 10:14 ` [PATCH 2/8] staging: et131x: Introduce et1310_in_phy_coma() call Mark Einon
2011-10-01 10:14 ` [PATCH 3/8] staging: et131x: Remove adapter->bmsr, replace with phydev equivalents Mark Einon
2011-10-01 10:14 ` [PATCH 4/8] staging: et131x: Add pci suspend & resume functions Mark Einon
2011-10-01 11:03 ` Francois Romieu
2011-10-01 14:02 ` Mark Einon
2011-10-01 19:36 ` Francois Romieu
2011-10-01 10:14 ` [PATCH 5/8] staging: et131x: Fix add_timer() from et131x_open Mark Einon
2011-10-01 10:14 ` [PATCH 6/8] staging: et131x: Update TODO file for kernel parameters Mark Einon
2011-10-01 10:14 ` [PATCH 7/8] staging: et131x: Updating copyright statements and module authors Mark Einon
2011-10-01 19:58 ` Dan Carpenter [this message]
2011-10-02 18:54 ` Mark Einon
2011-10-01 10:14 ` [PATCH 8/8] staging: et131x: Fix indefinite low power sleep Mark Einon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111001195835.GA2925@longonot.mountain \
--to=dan.carpenter@oracle.com \
--cc=alan@linux.intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.einon@gmail.com \
--cc=o.hartmann@telovital.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox