Re: [V6][PATCH 4/6] x86, nmi: add in logic to handle multiple events and unknown NMIs

Don Zickus
2011-09-26T12:56:34Z

On Mon, Sep 26, 2011 at 10:59:14AM +0200, Peter Zijlstra wrote:
> On Fri, 2011-09-23 at 15:17 -0400, Don Zickus wrote:
> > + /*
> > + * Use 'false' as back-to-back NMIs are dealt with one level up.
> > + * Of course this makes having multiple 'unknown' handlers useless
> > + * as only the first one is ever run (unless it can actually determine
> > + * if it caused the NMI)
> > + */
> > + handled = nmi_handle(NMI_UNKNOWN, regs, false);
>
> Shouldn't we then also add something like:
>
> WARN_ON_ONCE(type == NMI_UNKNOWN && !list_empty(&desc->head));

That would make sense.

Cheers,
Don