From: Adrian Bunk <bunk@stusta.de>
To: Andy Lutomirski <luto@mit.edu>,
"H. Peter Anvin" <hpa@linux.intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [3.1 patch] x86: default to vsyscall=native
Date: Mon, 3 Oct 2011 12:08:47 +0300 [thread overview]
Message-ID: <20111003090846.GA25136@localhost.pp.htv.fi> (raw)
After upgrading a kernel the existing userspace should just work
(assuming it did work before ;-) ), but when I upgraded my kernel
from 3.0.4 to 3.1.0-rc8 a UML instance didn't come up properly.
dmesg said:
linux-2.6.30.1[3800] vsyscall fault (exploit attempt?) ip:ffffffffff600000 cs:33 sp:7fbfb9c498 ax:ffffffffff600000 si:0 di:606790
linux-2.6.30.1[3856] vsyscall fault (exploit attempt?) ip:ffffffffff600000 cs:33 sp:7fbfb13168 ax:ffffffffff600000 si:0 di:606790
Looking throught the changelog I ended up at commit 3ae36655
("x86-64: Rework vsyscall emulation and add vsyscall= parameter").
Linus suggested in https://lkml.org/lkml/2011/8/9/376 to default to
vsyscall=native.
That sounds reasonable to me, and fixes the problem for me.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
Documentation/kernel-parameters.txt | 7 ++++---
arch/x86/kernel/vsyscall_64.c | 2 +-
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
index 854ed5ca..d6e6724 100644
--- a/Documentation/kernel-parameters.txt
+++ b/Documentation/kernel-parameters.txt
@@ -2706,10 +2706,11 @@ bytes respectively. Such letter suffixes can also be entirely omitted.
functions are at fixed addresses, they make nice
targets for exploits that can control RIP.
- emulate [default] Vsyscalls turn into traps and are
- emulated reasonably safely.
+ emulate Vsyscalls turn into traps and are emulated
+ reasonably safely.
- native Vsyscalls are native syscall instructions.
+ native [default] Vsyscalls are native syscall
+ instructions.
This is a little bit faster than trapping
and makes a few dynamic recompilers work
better than they would in emulation mode.
diff --git a/arch/x86/kernel/vsyscall_64.c b/arch/x86/kernel/vsyscall_64.c
index 18ae83d..b56c65de 100644
--- a/arch/x86/kernel/vsyscall_64.c
+++ b/arch/x86/kernel/vsyscall_64.c
@@ -56,7 +56,7 @@ DEFINE_VVAR(struct vsyscall_gtod_data, vsyscall_gtod_data) =
.lock = __SEQLOCK_UNLOCKED(__vsyscall_gtod_data.lock),
};
-static enum { EMULATE, NATIVE, NONE } vsyscall_mode = EMULATE;
+static enum { EMULATE, NATIVE, NONE } vsyscall_mode = NATIVE;
static int __init vsyscall_setup(char *str)
{
--
1.7.6.3
next reply other threads:[~2011-10-03 9:08 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-03 9:08 Adrian Bunk [this message]
2011-10-03 13:04 ` [3.1 patch] x86: default to vsyscall=native Andrew Lutomirski
2011-10-03 17:33 ` Adrian Bunk
2011-10-03 18:06 ` Andrew Lutomirski
2011-10-03 18:41 ` Adrian Bunk
2011-10-05 22:13 ` Andrew Lutomirski
2011-10-05 22:22 ` richard -rw- weinberger
2011-10-05 22:30 ` Adrian Bunk
2011-10-05 22:41 ` richard -rw- weinberger
2011-10-05 22:46 ` Andrew Lutomirski
2011-10-05 23:36 ` Andrew Lutomirski
2011-10-06 3:06 ` Andrew Lutomirski
2011-10-06 12:12 ` richard -rw- weinberger
2011-10-06 15:37 ` richard -rw- weinberger
2011-10-06 18:16 ` Andrew Lutomirski
2011-10-06 18:34 ` Linus Torvalds
2011-10-07 0:48 ` Andrew Lutomirski
2011-10-10 11:19 ` richard -rw- weinberger
2011-10-10 11:48 ` Ingo Molnar
2011-10-10 15:31 ` Andrew Lutomirski
2011-10-11 6:22 ` Ingo Molnar
2011-10-11 17:24 ` [RFC] fixing the UML failure root cause Andrew Lutomirski
2011-10-13 6:19 ` Linus Torvalds
2011-10-13 8:40 ` Andrew Lutomirski
2011-10-14 4:46 ` Linus Torvalds
2011-10-14 6:30 ` Andrew Lutomirski
2011-10-14 20:10 ` Linus Torvalds
2011-10-21 21:01 ` [PATCH] x86-64: Set siginfo and context on vsyscall emulation faults Andy Lutomirski
2011-10-22 4:46 ` Linus Torvalds
2011-10-22 9:07 ` Andy Lutomirski
2011-11-08 0:33 ` [PATCH 0/2] Fix and re-enable vsyscall=emulate Andy Lutomirski
2011-11-08 0:33 ` [PATCH 1/2] x86-64: Set siginfo and context on vsyscall emulation faults Andy Lutomirski
2011-12-05 13:23 ` [tip:x86/asm] " tip-bot for Andy Lutomirski
2011-11-08 0:33 ` [PATCH 2/2] x86: Default to vsyscall=emulate Andy Lutomirski
2011-12-05 13:24 ` [tip:x86/asm] " tip-bot for Andy Lutomirski
2011-12-02 22:47 ` [PATCH 0/2] Fix and re-enable vsyscall=emulate Andy Lutomirski
2011-12-05 11:18 ` H. Peter Anvin
2011-10-14 19:53 ` [RFC] fixing the UML failure root cause richard -rw- weinberger
2011-10-14 20:17 ` Andrew Lutomirski
2011-10-14 20:23 ` richard -rw- weinberger
2011-10-14 20:31 ` Andrew Lutomirski
2011-10-14 20:39 ` richard -rw- weinberger
2011-10-14 22:28 ` richard -rw- weinberger
2011-10-15 16:57 ` Ingo Molnar
2011-10-05 22:24 ` [3.1 patch] x86: default to vsyscall=native Adrian Bunk
2011-10-03 13:19 ` richard -rw- weinberger
2011-10-03 17:46 ` Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2011-10-05 21:40 Adrian Bunk
2011-10-05 22:01 ` Thomas Gleixner
2011-10-09 13:45 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111003090846.GA25136@localhost.pp.htv.fi \
--to=bunk@stusta.de \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@mit.edu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox