From: "Ted Ts'o" <tytso@mit.edu>
To: Lukas Czerner <lczerner@redhat.com>
Cc: Yongqiang Yang <xiaoqiangnk@gmail.com>,
Andreas Dilger <aedilger@gmail.com>,
Jeff liu <jeff.liu@oracle.com>,
Dave Young <hidave.darkstar@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-ext4@vger.kernel.org
Subject: Re: [BUG] copy file result with zero
Date: Mon, 3 Oct 2011 10:18:23 -0400 [thread overview]
Message-ID: <20111003141823.GA6684@thunk.org> (raw)
In-Reply-To: <alpine.LFD.2.00.1110031500430.4447@dhcp-27-109.brq.redhat.com>
On Mon, Oct 03, 2011 at 03:11:30PM +0200, Lukas Czerner wrote:
>
> Oops, you're right. I think that the best solution would be to revert
> the commit
>
> c03f8aa9abdd517477c2021ea1251939b4da49e6
> ext4: use FIEMAP_EXTENT_LAST flag for last extent in fiemap
>
> and then fix the original problem with your delayed extent tree
> solution, where we can easily check not only for next allocated extent,
> but also for next delayed extent to see if the current one is last or
> not.
> ...
>
> I do not know how "ready" are your patches..Is it possible to wait for
> them to be ready and fix it in your patch set ? That means, revert the
> mentioned commit and reimplement fiemap with delayed extent tree.
Sigh, yeah, we need to fix this to avoid the hang in xfstests #252 but
users losing data even if the coreutils release was only out there for
13 days is bad juju.
I'm working on reviewing the kernel patch backlog this week, and I'll
give this series one priority.
Thanks to Yongqiang and Lukas for looking into this!
- Ted
next prev parent reply other threads:[~2011-10-03 14:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-01 14:01 [BUG] copy file result with zero Dave Young
2011-10-01 14:39 ` Ted Ts'o
2011-10-01 23:37 ` Dave Young
2011-10-02 6:41 ` Jeff liu
2011-10-02 7:59 ` Andreas Dilger
2011-10-02 7:14 ` Jeff liu
2011-10-02 8:46 ` Dave Young
2011-10-02 11:54 ` Christoph Hellwig
2011-10-03 9:26 ` Yongqiang Yang
2011-10-03 13:11 ` Lukas Czerner
2011-10-03 14:18 ` Ted Ts'o [this message]
2011-10-03 15:51 ` Lukas Czerner
2011-10-02 8:02 ` Andreas Dilger
2011-10-02 8:43 ` Dave Young
2011-10-03 11:08 ` Pádraig Brady
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111003141823.GA6684@thunk.org \
--to=tytso@mit.edu \
--cc=aedilger@gmail.com \
--cc=hidave.darkstar@gmail.com \
--cc=jeff.liu@oracle.com \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiaoqiangnk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox