Re: [PATCH] perf tools: Exit recording if events have non matching sample type

[Arnaldo Carvalho de Melo <acme@ghostprotocols.net>]

Em Tue, Oct 04, 2011 at 12:00:12PM +0200, Peter Zijlstra escreveu:
> On Mon, 2011-10-03 at 22:14 -0600, David Ahern wrote:
> > On 09/30/2011 01:39 AM, Peter Zijlstra wrote:
> > > On Thu, 2011-09-29 at 17:33 -0600, David Ahern wrote:
> > >>> For record that means we need to dump each per-sample_id mmap onto a
> > >>> separate file, i.e. use a directory, etc.

> > >> That seems like a major re-write of perf. 

> > > Well we want to go there anyway. A file per cpu stream can be a lot less
> > > overhead than one file for all cpu streams.

> > really it becomes file per cpu stream and per sample type. So a dual
> > socket, quad core with HT means 16 files per sample type. ie., the
> > number of files explodes quick.

> > I understand the allure for simplicity during the data collection. Has
> > any thought been given on management of the files in such a scenario?
> > User specifies a directory path instead of a file path - or both to
> > handle backward compatibility?

> I think the idea was a directory and a script to convert old data files
> to the new format. But it was a while ago acme and I talked about this.

I don't remember the script idea, but that would work too.

WRT major rewrites, well, as we go on developing any piece of software,
those kinds of things happen :-)

If it is to improve things, make them faster, cope with new hardware
realities, keep our jobs, so be it! ;-)

- Arnaldo