From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, Kenneth Kiraly <kiraly@lab126.com>,
Liam Girdwood <lrg@ti.com>,
alsa-devel@alsa-project.org
Subject: Re: [RFC][PATCH] ASoC: Avoid writing to WM8971_RESET in wm8971_resume
Date: Tue, 4 Oct 2011 16:04:04 +0100 [thread overview]
Message-ID: <20111004150403.GI6934@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1317685462.3640.2.camel@phoenix>
On Tue, Oct 04, 2011 at 07:44:22AM +0800, Axel Lin wrote:
> While reading the code, I don't understand why we need to do (in wm8971_resume):
>
> for (i = 0; i < ARRAY_SIZE(wm8971_reg); i++) {
> if (i + 1 == WM8971_RESET)
> continue;
>
> My understanding is that we want to avoid writing to WM8971_RESET on resume.
Yeah, this looks like a leftover from some older code which omitted
register zero from the cache for some small memory savings. Now things
are using the standard cache code rather than custom cache code this
is buggy.
Applied, thanks.
prev parent reply other threads:[~2011-10-04 15:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-03 23:44 [RFC][PATCH] ASoC: Avoid writing to WM8971_RESET in wm8971_resume Axel Lin
2011-10-04 15:04 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111004150403.GI6934@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@gmail.com \
--cc=kiraly@lab126.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox