Re: [Quilt-dev] [RFC][PATCH v2][QUILT] Add gpg signing to quilt mail

[Greg KH <gregkh@suse.de>]

On Wed, Oct 05, 2011 at 03:48:26AM +0200, Andreas Gruenbacher wrote:
> On Tue, 2011-10-04 at 14:37 -0400, Steven Rostedt wrote:
> > On Tue, 2011-10-04 at 11:26 -0700, Greg KH wrote:
> > 
> > > > What are git's "split" subject: lines?
> > > 
> > > Do the following:
> > >  $ git show --pretty=email 21d17dd2a377ba894f26989915eb3c6e427a3656
> > > 
> > > and look at how the Subject line is formatted:
> > > 	Subject: [PATCH] ASoC: Fix setting update bits for WM8753_LADC and
> > > 	 WM8753_RADC
> > > 
> > > Which is legal for email subject lines.  But quilt can't handle this and
> > > ends up thinking the data after the Subject: line is part of the patch
> > > text body and messes stuff up when doing 'quilt mail' later.
> 
> Aah, all this email parsing code is so ugly.  I think it works now
> though.

"now" meaning which version of quilt?  I still see this on 0.48 if that
matters.

> > > Oh, then there's the issue of quilt not handling ',' in a Signed-off-by
> > > line as a valid email address name, but I've been living with that one
> > > for years...
> 
> That's not even valid in email addresses.  The proper way would be to
> double-quote the "display name" which probably contains the comma, but
> then quilt's edmail script still won't understand it.  Is this a real
> problem?

Yes, quoting is the correct thing to do, but that does not usually
happen in "Signed-off-by:" lines in kernel patches.

Actually, I think this is even a problem when the name is quoted
properly, I've had to fix that up in patches by hand.

And yes, this is a problem, I run into at least 1-2 patches per stable
kernel release with this issue.  I looked into fixing it and somehow the
email parsing logic was wierd and I couldn't figure out how to resolve
it.

thanks,

greg k-h