From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: greg@kroah.com, linux-kernel@vger.kernel.org
Subject: Re: [RFC] drivercore: Add helper macro for platform_driver boilerplate
Date: Wed, 5 Oct 2011 11:02:45 +0100 [thread overview]
Message-ID: <20111005100244.GA9783@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20111004232403.10364.22050.stgit@ponder>
On Tue, Oct 04, 2011 at 05:26:55PM -0600, Grant Likely wrote:
> +/* Helper macro for drivers that don't do anything special in module
> + * init/exit. This eliminates a lot of boilerplate */
> +#define module_platform_driver(__platform_driver) \
> +int __platform_driver##_init(void) \
> +{ \
> + return platform_driver_register(&(__platform_driver)); \
> +} \
> +module_init(__platform_driver##_init); \
This looks great but I would prefer it if the function complained if
something goes wrong - it makes problems a lot more discoverable when
they crop up.
next prev parent reply other threads:[~2011-10-05 10:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-04 23:26 [RFC] drivercore: Add helper macro for platform_driver boilerplate Grant Likely
2011-10-05 6:56 ` Greg KH
2011-10-05 16:43 ` Grant Likely
2011-10-05 19:29 ` Greg KH
2011-12-04 8:39 ` Geert Uytterhoeven
2011-12-04 9:36 ` Lars-Peter Clausen
2011-12-04 10:27 ` Geert Uytterhoeven
2011-10-05 8:12 ` Magnus Damm
2011-10-05 10:02 ` Mark Brown [this message]
2011-10-05 16:42 ` Grant Likely
2011-10-05 21:37 ` Stephen Boyd
2011-10-06 0:58 ` Grant Likely
2011-10-06 11:40 ` Jonathan Cameron
2011-10-06 14:50 ` Mike Frysinger
2011-10-06 18:35 ` Tabi Timur-B04825
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111005100244.GA9783@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=grant.likely@secretlab.ca \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox