From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lrg@ti.com>,
alsa-devel@alsa-project.org
Subject: Re: [RFC][PATCH] ASoC: Fix sync reg_cache with the hardware in wm8990_resume
Date: Wed, 5 Oct 2011 11:21:22 +0100 [thread overview]
Message-ID: <20111005102122.GB9783@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1317809809.2374.5.camel@phoenix>
On Wed, Oct 05, 2011 at 06:16:49PM +0800, Axel Lin wrote:
> Current code has off-by-one bug of checking WM8990_RESET.
> Besides, according to wm8990 datasheet (2-wire serial control mode):
> A control word consists of 24 bits. The first 8 bits are address bits,
> the remaining 16 bits are data bits.
> Current code uses 7 bits address bits and 9 bits data bits which is incorrect.
We should just convert drivers like this to snd_soc_cache_sync().
next prev parent reply other threads:[~2011-10-05 10:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-05 10:16 [RFC][PATCH] ASoC: Fix sync reg_cache with the hardware in wm8990_resume Axel Lin
2011-10-05 10:21 ` Mark Brown [this message]
2011-10-05 10:39 ` Axel Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111005102122.GB9783@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox