From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, Richard Purdie <rpurdie@rpsys.net>,
Liam Girdwood <lrg@ti.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: ak4535: Set codec->hw_write to i2c_master_send
Date: Wed, 5 Oct 2011 17:16:21 +0100 [thread overview]
Message-ID: <20111005161620.GB11528@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1317799677.21481.6.camel@phoenix>
On Wed, Oct 05, 2011 at 03:27:56PM +0800, Axel Lin wrote:
> It was removed in commit f0fba2ad
> "ASoC: multi-component - ASoC Multi-Component Support".
>
> Add it back, otherwise codec->hw_write points to NULL.
It's better to fix the driver not to use hw_write any more, it's broken
without anyway.
next prev parent reply other threads:[~2011-10-05 16:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-05 7:27 [PATCH] ASoC: ak4535: Set codec->hw_write to i2c_master_send Axel Lin
2011-10-05 16:16 ` Mark Brown [this message]
2011-10-05 23:46 ` Axel Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111005161620.GB11528@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox