* [PATCH] ASoC: ak4535: Set codec->hw_write to i2c_master_send
@ 2011-10-05 7:27 Axel Lin
2011-10-05 16:16 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Axel Lin @ 2011-10-05 7:27 UTC (permalink / raw)
To: linux-kernel; +Cc: Richard Purdie, Liam Girdwood, Mark Brown, alsa-devel
It was removed in commit f0fba2ad
"ASoC: multi-component - ASoC Multi-Component Support".
Add it back, otherwise codec->hw_write points to NULL.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
sound/soc/codecs/ak4535.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/sound/soc/codecs/ak4535.c b/sound/soc/codecs/ak4535.c
index e1a214e..00cc92c 100644
--- a/sound/soc/codecs/ak4535.c
+++ b/sound/soc/codecs/ak4535.c
@@ -439,6 +439,7 @@ static int ak4535_probe(struct snd_soc_codec *codec)
printk(KERN_INFO "AK4535 Audio Codec %s", AK4535_VERSION);
+ codec->hw_write = (hw_write_t)i2c_master_send;
codec->control_data = ak4535->control_data;
/* power on device */
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: ak4535: Set codec->hw_write to i2c_master_send
2011-10-05 7:27 [PATCH] ASoC: ak4535: Set codec->hw_write to i2c_master_send Axel Lin
@ 2011-10-05 16:16 ` Mark Brown
2011-10-05 23:46 ` Axel Lin
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2011-10-05 16:16 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Richard Purdie, Liam Girdwood, alsa-devel
On Wed, Oct 05, 2011 at 03:27:56PM +0800, Axel Lin wrote:
> It was removed in commit f0fba2ad
> "ASoC: multi-component - ASoC Multi-Component Support".
>
> Add it back, otherwise codec->hw_write points to NULL.
It's better to fix the driver not to use hw_write any more, it's broken
without anyway.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: ak4535: Set codec->hw_write to i2c_master_send
2011-10-05 16:16 ` Mark Brown
@ 2011-10-05 23:46 ` Axel Lin
0 siblings, 0 replies; 3+ messages in thread
From: Axel Lin @ 2011-10-05 23:46 UTC (permalink / raw)
To: Mark Brown; +Cc: linux-kernel, Richard Purdie, Liam Girdwood, alsa-devel
2011/10/6 Mark Brown <broonie@opensource.wolfsonmicro.com>:
> On Wed, Oct 05, 2011 at 03:27:56PM +0800, Axel Lin wrote:
>> It was removed in commit f0fba2ad
>> "ASoC: multi-component - ASoC Multi-Component Support".
>>
>> Add it back, otherwise codec->hw_write points to NULL.
>
> It's better to fix the driver not to use hw_write any more, it's broken
> without anyway.
>
It's better convert to soc-cache.
But this one-line-fix may be ok for 3.1.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-10-05 23:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-05 7:27 [PATCH] ASoC: ak4535: Set codec->hw_write to i2c_master_send Axel Lin
2011-10-05 16:16 ` Mark Brown
2011-10-05 23:46 ` Axel Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox