From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935443Ab1JEWOp (ORCPT ); Wed, 5 Oct 2011 18:14:45 -0400 Received: from cantor2.suse.de ([195.135.220.15]:46570 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755530Ab1JEWOo (ORCPT ); Wed, 5 Oct 2011 18:14:44 -0400 Date: Thu, 6 Oct 2011 00:14:42 +0200 From: Jan Kara To: Namjae Jeon Cc: jack@suse.cz, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2 v2] udf : add readpages support for udf. Message-ID: <20111005221442.GL23467@quack.suse.cz> References: <1317618179-22176-1-git-send-email-linkinjeon@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1317618179-22176-1-git-send-email-linkinjeon@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 03-10-11 14:02:59, Namjae Jeon wrote: > Using mpage_readpages instead of multiple calls to udf_readpage to reduce the CPU utilization and make performance higher. Thanks. I've merged this patch. Honza > > Signed-off-by: Namjae Jeon > --- > fs/udf/inode.c | 10 +++++++++- > 1 files changed, 9 insertions(+), 1 deletions(-) > > diff --git a/fs/udf/inode.c b/fs/udf/inode.c > index 58665ce..81f9ce1 100644 > --- a/fs/udf/inode.c > +++ b/fs/udf/inode.c > @@ -37,6 +37,7 @@ > #include > #include > #include > +#include > > #include "udf_i.h" > #include "udf_sb.h" > @@ -104,7 +105,13 @@ static int udf_writepage(struct page *page, struct writeback_control *wbc) > > static int udf_readpage(struct file *file, struct page *page) > { > - return block_read_full_page(page, udf_get_block); > + return mpage_readpage(page, udf_get_block); > +} > + > +static int udf_readpages(struct file *file, struct address_space *mapping, > + struct list_head *pages, unsigned nr_pages) > +{ > + return mpage_readpages(mapping, pages, nr_pages, udf_get_block); > } > > static int udf_write_begin(struct file *file, struct address_space *mapping, > @@ -139,6 +146,7 @@ static sector_t udf_bmap(struct address_space *mapping, sector_t block) > > const struct address_space_operations udf_aops = { > .readpage = udf_readpage, > + .readpages = udf_readpages, > .writepage = udf_writepage, > .write_begin = udf_write_begin, > .write_end = generic_write_end, > -- > 1.7.4.4 > -- Jan Kara SUSE Labs, CR