From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: Axel Lin <axel.lin@gmail.com>,
linux-kernel@vger.kernel.org,
Ian Lartey <ian@opensource.wolfsonmicro.com>,
Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@ti.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH 06/10] ASoC: wm8940: Convert to snd_soc_cache_sync
Date: Thu, 6 Oct 2011 14:18:12 +0100 [thread overview]
Message-ID: <20111006131811.GA16404@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4E8D90E9.5060208@cam.ac.uk>
On Thu, Oct 06, 2011 at 12:28:41PM +0100, Jonathan Cameron wrote:
> On 10/06/11 07:17, Axel Lin wrote:
> > +static int wm8940_volatile_register(struct snd_soc_codec *codec,
> > + unsigned int reg)
> > +{
> > + switch (reg) {
> > + case WM8940_SOFTRESET:
> > + return 1;
> > + default:
> > + return 0;
> > + }
> > +}
> I guess this makes sense from point of view of keeping things inline with
> more complex drivers. Otherwise I'd expect to see something like:
> {
> return !!(reg == WM894_SOFTRESET);
> }
On the other hand we actually want people to be able to read the code
(though the !! there which is the major complication isn't actually
doing anything...).
next prev parent reply other threads:[~2011-10-06 13:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-06 6:10 [PATCH 00/10] Convert wm8xxx codec drivers to use snd_soc_cache_sync Axel Lin
2011-10-06 6:11 ` [PATCH 01/10] ASoC: wm8510: Convert to snd_soc_cache_sync Axel Lin
2011-10-06 13:22 ` Mark Brown
2011-10-06 6:13 ` [PATCH 02/10] ASoC: wm8711: " Axel Lin
2011-10-06 6:14 ` [PATCH 03/10] ASoC: wm8731: " Axel Lin
2011-10-06 6:15 ` [PATCH 04/10] ASoC: wm8750: " Axel Lin
2011-10-06 6:16 ` [PATCH 05/10] ASoC: wm8776: " Axel Lin
2011-10-06 6:17 ` [PATCH 06/10] ASoC: wm8940: " Axel Lin
2011-10-06 11:28 ` Jonathan Cameron
2011-10-06 11:33 ` Axel Lin
2011-10-06 13:18 ` Mark Brown [this message]
2011-10-06 13:35 ` Jonathan Cameron
2011-10-06 6:18 ` [PATCH 07/10] ASoC: wm8960: " Axel Lin
2011-10-06 7:25 ` [PATCH 07/10 v2] " Axel Lin
2011-10-06 6:19 ` [PATCH 08/10] ASoC: wm8971: " Axel Lin
2011-10-06 6:20 ` [PATCH 09/10] ASoC: wm8974: " Axel Lin
2011-10-06 6:21 ` [PATCH 10/10] ASoC: wm8988: " Axel Lin
2011-10-06 6:52 ` [PATCH 00/10] Convert wm8xxx codec drivers to use snd_soc_cache_sync Axel Lin
2011-10-06 7:10 ` Axel Lin
2011-10-06 10:14 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111006131811.GA16404@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@gmail.com \
--cc=dp@opensource.wolfsonmicro.com \
--cc=ian@opensource.wolfsonmicro.com \
--cc=jic23@cam.ac.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox