From: Greg KH <greg@kroah.com>
To: Himanshu Chauhan <hschauhan@nulltrace.org>
Cc: linux-kernel@vger.kernel.org, kernelnewbies@kernelnewbies.org,
lm-sensors@lm-sensors.org
Subject: Re: [PATCH] hwmon class driver registration with a device number
Date: Thu, 6 Oct 2011 11:25:00 -0700 [thread overview]
Message-ID: <20111006182500.GA18607@kroah.com> (raw)
In-Reply-To: <20111006041011.GB2125@ubuntu.ubuntu-domain>
On Thu, Oct 06, 2011 at 09:40:11AM +0530, Himanshu Chauhan wrote:
> Hi Greg,
>
> >
> > How do you later remove a device created with this new interface? As it
> > is, I think the existing calls will fail, right?
> >
> If I have not missed out anything from hwmon_device_unregister(), it shouldn't
> fail. Why did you point that out?
If you create a device with a call to device_create() with a dev_t set,
it is usually cleaned up with a call to device_destroy(), but you are
right, a simple call to device_unregister() will still work properly.
So nevermind, sorry for the noise.
What you do need to determine is if this is a device node you really
want to be creating in this manner, as it is a new user/kernel API,
right?
greg k-h
next prev parent reply other threads:[~2011-10-06 18:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-05 17:13 [PATCH] hwmon class driver registration with a device number Himanshu Chauhan
2011-10-05 18:30 ` Guenter Roeck
2011-10-06 4:06 ` Himanshu Chauhan
2011-10-06 5:19 ` Guenter Roeck
2011-10-06 7:43 ` [lm-sensors] " Jean Delvare
2011-10-06 15:12 ` Himanshu Chauhan
2011-10-06 15:46 ` Alan Cox
2011-10-06 16:25 ` Himanshu Chauhan
2011-10-06 15:15 ` Guenter Roeck
2011-10-06 16:43 ` Himanshu Chauhan
2011-10-05 19:33 ` Greg KH
2011-10-06 4:10 ` Himanshu Chauhan
2011-10-06 18:25 ` Greg KH [this message]
2011-10-06 19:07 ` [lm-sensors] " Guenter Roeck
2011-10-07 6:42 ` Himanshu Chauhan
2011-10-07 6:52 ` Greg KH
2011-10-07 9:56 ` Himanshu Chauhan
2011-10-07 11:11 ` Jonathan Cameron
2011-10-07 15:46 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111006182500.GA18607@kroah.com \
--to=greg@kroah.com \
--cc=hschauhan@nulltrace.org \
--cc=kernelnewbies@kernelnewbies.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox