public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: RFC: virtualbox tainting.
Date: Thu, 6 Oct 2011 15:05:27 -0400	[thread overview]
Message-ID: <20111006190526.GA13883@redhat.com> (raw)

The number of bug reports we get from people with virtualbox loaded are
truly astonishing.  It's GPL, but sadly that doesn't mean it's good.
Nearly all of these bugs look like random corruption. (corrupt linked lists,
corrupt page tables, and just plain 'weird' crashes).

This diff adds tainting to the module loader to treat it as we do with stuff
from staging/ (crap). With this tainting in place, automatic bug filing tools
can opt out of automatically filing kernel bugs, and inform the user to file
bugs somewhere more appropriate.

Signed-off-by: Dave Jones <davej@redhat.com>

diff --git a/kernel/module.c b/kernel/module.c
index 04379f92..d26c9a3 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -2653,6 +2653,10 @@ static int check_module_license_and_versions(struct module *mod)
 	if (strcmp(mod->name, "ndiswrapper") == 0)
 		add_taint(TAINT_PROPRIETARY_MODULE);
 
+	/* vbox is garbage. */
+	if (strcmp(mod->name, "vboxdrv") == 0)
+		add_taint(TAINT_CRAP);
+
 	/* driverloader was caught wrongly pretending to be under GPL */
 	if (strcmp(mod->name, "driverloader") == 0)
 		add_taint_module(mod, TAINT_PROPRIETARY_MODULE);

             reply	other threads:[~2011-10-06 19:05 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-06 19:05 Dave Jones [this message]
2011-10-06 19:44 ` RFC: virtualbox tainting Greg KH
2011-10-06 19:50   ` Dave Jones
2011-10-06 19:53     ` Valdis.Kletnieks
2011-10-06 20:03       ` Dave Jones
2011-10-06 20:06       ` Greg KH
2011-10-06 19:58     ` Greg KH
2011-10-06 20:04       ` Dave Jones
2011-10-06 20:30         ` Greg KH
2011-10-07  8:01         ` Jiri Kosina
2011-10-07 10:02           ` Alan Cox
2011-10-07 16:04           ` Valdis.Kletnieks
2011-10-07 17:01             ` Greg KH
2011-10-07 17:46               ` Dave Jones
2011-10-07  7:03       ` Bastian Blank
2011-10-07 14:40 ` Frank Mehnert
2011-10-07 15:10   ` Dave Jones
2011-10-09 20:12     ` Frank Mehnert
2011-10-07 15:16   ` Josh Boyer
2011-10-07 16:22     ` Valdis.Kletnieks
2011-10-07 18:10       ` Josh Boyer
2011-10-07 18:33         ` Valdis.Kletnieks
2011-10-10  7:58   ` Pekka Enberg
2011-10-10  8:25     ` Dave Airlie
2011-10-10 14:24     ` Greg KH
2011-10-10 16:35       ` Pekka Enberg
2011-10-10 16:49         ` Dave Airlie
2011-10-10 16:51           ` Pekka Enberg
2011-10-10  8:41 ` Maarten Lankhorst
2011-10-10 11:42   ` Josh Boyer
2011-10-12  0:57 ` Parag Warudkar
2011-10-12  7:55   ` Alex Riesen
2011-10-12 14:08     ` Parag Warudkar
2011-10-12 14:18       ` Alex Riesen
2011-10-12 15:00         ` Parag Warudkar
2011-10-12 19:55   ` Zan Lynx
2011-10-12 20:54     ` Parag Warudkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111006190526.GA13883@redhat.com \
    --to=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox