Re: RFC: virtualbox tainting.

Greg KH
2011-10-06T19:44:47Z

On Thu, Oct 06, 2011 at 03:05:27PM -0400, Dave Jones wrote:
> The number of bug reports we get from people with virtualbox loaded are
> truly astonishing. It's GPL, but sadly that doesn't mean it's good.
> Nearly all of these bugs look like random corruption. (corrupt linked lists,
> corrupt page tables, and just plain 'weird' crashes).
>
> This diff adds tainting to the module loader to treat it as we do with stuff
> from staging/ (crap). With this tainting in place, automatic bug filing tools
> can opt out of automatically filing kernel bugs, and inform the user to file
> bugs somewhere more appropriate.
>
> Signed-off-by: Dave Jones <davej@redhat.com>
>
> diff --git a/kernel/module.c b/kernel/module.c
> index 04379f92..d26c9a3 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -2653,6 +2653,10 @@ static int check_module_license_and_versions(struct module *mod)
> if (strcmp(mod->name, "ndiswrapper") == 0)
> add_taint(TAINT_PROPRIETARY_MODULE);
>
> + /* vbox is garbage. */
> + if (strcmp(mod->name, "vboxdrv") == 0)
> + add_taint(TAINT_CRAP);

Odds are we should have a list of these types of modules, as I think
there are a few others out there we should mark this way :)

But anyway, I like this, and I think I'll go add it to the openSUSE
kernels so we can avoid the numerous bug reports we get there as well
for this crappy driver.

Acked-by: Greg Kroah-Hartman <gregkh@suse.de>

greg k-h