Re: [PATCH 3/4] PCI: Add implementation for PRI capability

Roedel, Joerg
2011-10-30T14:57:17Z

On Sat, Oct 29, 2011 at 03:36:13PM -0400, Geert Uytterhoeven wrote:
> On Tue, Sep 27, 2011 at 15:57, Joerg Roedel <joerg.roedel@amd.com> wrote:
> > Implement the necessary functions to handle PRI capabilities
> > on PCIe devices. With PRI devices behind an IOMMU can signal
> > page fault conditions to software and recover from such
> > faults.
> >
> > Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
> > ---
> >  drivers/pci/Kconfig      |    9 +++
> >  drivers/pci/ats.c        |  167 ++++++++++++++++++++++++++++++++++++++++++++++
> >  include/linux/pci-ats.h  |   42 ++++++++++++
> >  include/linux/pci_regs.h |   12 +++
> >  4 files changed, 230 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig
> > index 1d8ce83..fb1e9707 100644
> > --- a/drivers/pci/Kconfig
> > +++ b/drivers/pci/Kconfig
> > @@ -85,6 +85,15 @@ config PCI_IOV
> >
> >          If unsure, say N.
> >
> > +config PCI_PRI
> > +       bool "PCI PRI support"
>
> Shouldn't this depend on PCI?
>
> It doesn't seem to hurt on PCI-less platforms, but I prefer not seeing
> PCI-related questions when CONFIG_PCI is not set.

You are right, I send a fix soon. Thanks for the report.

Joerg

--
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632