Re: [PATCH 3/4] PCI: Add implementation for PRI capability

Geert Uytterhoeven
2011-10-29T19:46:09Z

On Tue, Sep 27, 2011 at 15:57, Joerg Roedel <joerg.roedel@amd.com> wrote:
> Implement the necessary functions to handle PRI capabilities
> on PCIe devices. With PRI devices behind an IOMMU can signal
> page fault conditions to software and recover from such
> faults.
>
> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
> ---
>  drivers/pci/Kconfig      |    9 +++
>  drivers/pci/ats.c        |  167 ++++++++++++++++++++++++++++++++++++++++++++++
>  include/linux/pci-ats.h  |   42 ++++++++++++
>  include/linux/pci_regs.h |   12 +++
>  4 files changed, 230 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig
> index 1d8ce83..fb1e9707 100644
> --- a/drivers/pci/Kconfig
> +++ b/drivers/pci/Kconfig
> @@ -85,6 +85,15 @@ config PCI_IOV
>
>          If unsure, say N.
>
> +config PCI_PRI
> +       bool "PCI PRI support"

Shouldn't this depend on PCI?

It doesn't seem to hurt on PCI-less platforms, but I prefer not seeing
PCI-related
questions when CONFIG_PCI is not set.

> +       select PCI_ATS
> +       help
> +         PRI is the PCI Page Request Interface. It allows PCI devices that are
> +         behind an IOMMU to recover from page faults.
> +
> +         If unsure, say N.
> +

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds