From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752766Ab1JHKXX (ORCPT ); Sat, 8 Oct 2011 06:23:23 -0400 Received: from mail-ww0-f42.google.com ([74.125.82.42]:61304 "EHLO mail-ww0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752631Ab1JHKXV (ORCPT ); Sat, 8 Oct 2011 06:23:21 -0400 Date: Sat, 8 Oct 2011 11:23:13 +0100 From: Jamie Iles To: Russell King - ARM Linux Cc: Eric Miao , Jason Chagas , Haojian Zhuang , linux-arm-kernel@lists.infradead.org, Arnd Bergmann , linux-kernel@vger.kernel.org Subject: Re: [PATCH 06/26] ARM: pxa: add missing header inclusions Message-ID: <20111008102313.GA4464@gallagher> References: <1317499438-14058-1-git-send-email-arnd@arndb.de> <1317499438-14058-7-git-send-email-arnd@arndb.de> <20111008080309.GD25689@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20111008080309.GD25689@n2100.arm.linux.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 08, 2011 at 09:03:09AM +0100, Russell King - ARM Linux wrote: > On Fri, Oct 07, 2011 at 01:08:23PM +0800, Eric Miao wrote: > > On Sun, Oct 2, 2011 at 4:03 AM, Arnd Bergmann wrote: > > > These resulted in build breakage in some configurations: > > > > > > arch/arm/mach-pxa/irq.c:132:39: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'icip_handle_irq' > > > > > > Signed-off-by: Arnd Bergmann > > > --- > > >  arch/arm/mach-pxa/irq.c |    1 + > > >  1 files changed, 1 insertions(+), 0 deletions(-) > > > > > > diff --git a/arch/arm/mach-pxa/irq.c b/arch/arm/mach-pxa/irq.c > > > index b09e848..848e96d 100644 > > > --- a/arch/arm/mach-pxa/irq.c > > > +++ b/arch/arm/mach-pxa/irq.c > > > @@ -16,6 +16,7 @@ > > >  #include > > >  #include > > >  #include > > > +#include > > > > It's actually __irq_entry being defined in and in turn > > __exception_irq_entry being conditionally defined to that. > > > > I think it's better to fix this in instead of in the > > cases where this macro is referenced? > > > > Russell? > > There's a patch in the patch system which fixes this (7115/3) but I > can't apply it because it doesn't apply to anything in my for-next > tree (it applies to the obsolete 'devel' branch which is rather old > now.) OK, I wasn't aware that devel was obsolete (though I guess if I'd paid closer attention to the commit dates I'd have suspected something). Anyhow, new patch in the tracker as 7115/4 rebased onto for-next. Jamie