From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751480Ab1JINgl (ORCPT ); Sun, 9 Oct 2011 09:36:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40677 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750922Ab1JINgk (ORCPT ); Sun, 9 Oct 2011 09:36:40 -0400 Date: Sun, 9 Oct 2011 15:31:40 +0200 From: Oleg Nesterov To: Srikar Dronamraju Cc: Peter Zijlstra , Ingo Molnar , Steven Rostedt , Linux-mm , Arnaldo Carvalho de Melo , Linus Torvalds , Jonathan Corbet , Hugh Dickins , Christoph Hellwig , Masami Hiramatsu , Thomas Gleixner , Ananth N Mavinakayanahalli , Andrew Morton , Jim Keniston , Roland McGrath , Andi Kleen , LKML Subject: Re: [PATCH v5 3.1.0-rc4-tip 12/26] Uprobes: Handle breakpoint and Singlestep Message-ID: <20111009133139.GA28332@redhat.com> References: <20110920115938.25326.93059.sendpatchset@srdronam.in.ibm.com> <20110920120221.25326.74714.sendpatchset@srdronam.in.ibm.com> <20111007182834.GA1655@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111007182834.GA1655@redhat.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/07, Oleg Nesterov wrote: > > What if the forking task (current) is in UTASK_BP_HIT state? > ... > > And what if we step into a syscall insn? > ... And I guess there would be a lot more problems here. But, looking at is_prefix_bad() I see the nice comment: * opcodes we'll probably never support: * 0f - lar, lsl, syscall, clts, sysret, sysenter, sysexit, invd, wbinvd, ud2 This answers my questions. > Please simply ignore my email if you think everything is fine. Yep. Oleg.