From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH 2/2] regmap: Allow caches for devices with no defaults
Date: Mon, 10 Oct 2011 10:23:46 +0100 [thread overview]
Message-ID: <20111010092345.GA3040@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20111010084126.GA2563@opensource.wolfsonmicro.com>
On Mon, Oct 10, 2011 at 09:41:26AM +0100, Dimitris Papastamos wrote:
> On Sun, Oct 09, 2011 at 02:44:36PM +0100, Mark Brown wrote:
> > + } else if (map->num_reg_defaults_raw) {
> > /* Some devices such as PMICs don't have cache defaults,
> > * we cope with this by reading back the HW registers and
> > * crafting the cache defaults by hand.
> We could probably then also remove the first check in
> regcache_hw_init() I guess.
> The one:
> if (!map->num_reg_defaults_raw)
> return -EINVAL;
I felt it was clearer to have the defaults init fail if it doesn't work
so that the callers know what happened. Otherwise the callers have to
figure out if it succeeded because it did what it was supposed to.
next prev parent reply other threads:[~2011-10-10 9:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-09 13:44 [PATCH 1/2] regmap: Return a sensible error code if we fail to read the cache Mark Brown
2011-10-09 13:44 ` [PATCH 2/2] regmap: Allow caches for devices with no defaults Mark Brown
2011-10-09 17:43 ` Valdis.Kletnieks
2011-10-09 19:34 ` Mark Brown
2011-10-10 8:41 ` Dimitris Papastamos
2011-10-10 9:23 ` Mark Brown [this message]
2011-10-10 10:50 ` Dimitris Papastamos
2011-10-10 9:03 ` [PATCH 1/2] regmap: Return a sensible error code if we fail to read the cache Dimitris Papastamos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111010092345.GA3040@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=dp@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox