From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753521Ab1JJK2M (ORCPT ); Mon, 10 Oct 2011 06:28:12 -0400 Received: from mga14.intel.com ([143.182.124.37]:3627 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753315Ab1JJK2I (ORCPT ); Mon, 10 Oct 2011 06:28:08 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.68,516,1312182000"; d="scan'208";a="60600772" Date: Mon, 10 Oct 2011 12:31:19 +0200 From: Samuel Ortiz To: Linus Walleij Cc: linux-kernel@vger.kernel.org, Lee Jones , Mattias Nilsson , Linus Walleij Subject: Re: [PATCH 09/23] mfd/db8500-prcmu: tweak for modem wakeup Message-ID: <20111010103119.GA12134@sortiz-mobl> References: <1313137723-30881-1-git-send-email-linus.walleij@stericsson.com> <20111003155207.GP4118@sortiz-mobl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111003155207.GP4118@sortiz-mobl> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Linus, On Mon, Oct 03, 2011 at 05:52:07PM +0200, Samuel Ortiz wrote: > Hi Linus, > > On Fri, Aug 12, 2011 at 10:28:43AM +0200, Linus Walleij wrote: > > @@ -1754,11 +1755,34 @@ void prcmu_ac_wake_req(void) > > > > atomic_set(&ac_wake_req_state, 1); > > > > +retry: > > writel((val | PRCM_HOSTACCESS_REQ_HOSTACCESS_REQ), PRCM_HOSTACCESS_REQ); > > > > if (!wait_for_completion_timeout(&mb0_transfer.ac_wake_work, > > - msecs_to_jiffies(20000))) { > > - pr_err("prcmu: %s timed out (20 s) waiting for a reply.\n", > > + msecs_to_jiffies(5000))) { > > + panic("prcmu: %s timed out (5 s) waiting for a reply.\n", > > + __func__); > panic(), really ? What about this one. Do we really want to panic here ? Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/